Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synoptic Form Bug Fixes #152

Merged
merged 6 commits into from
Oct 7, 2024
Merged

Synoptic Form Bug Fixes #152

merged 6 commits into from
Oct 7, 2024

Conversation

AbnerBissolli
Copy link
Collaborator

@AbnerBissolli AbnerBissolli commented Sep 18, 2024 •
edited
Loading

This PR addresses bugs identified by @akeishamaldonado and @scottylad501, as well as their requested changes.

Notes:

  • Added the precipitation duration variable (PRECDUR) to synoptic capture, removing the previous automatic calculation for precipitation duration.

@AbnerBissolli AbnerBissolli self-assigned this Sep 18, 2024
@cla-bot cla-bot bot added the cla-signed label Sep 18, 2024
@AbnerBissolli AbnerBissolli marked this pull request as ready for review September 19, 2024 20:44
@AbnerBissolli AbnerBissolli changed the title [WIP] Synoptic Form Bug Fixes Synoptic Form Bug Fixes Sep 19, 2024
fabiosato
fabiosato approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@fabiosato fabiosato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AbnerBissolli AbnerBissolli merged commit 624d7fa into development Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiosato fabiosato fabiosato approved these changes

Assignees

@AbnerBissolli AbnerBissolli

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbnerBissolli @fabiosato