feat: Kong Plugin #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrimIdan
requested changes
Nov 10, 2021
plugins/gateway/kong/plugin.go
Outdated
Comment on lines
173
to
174
| var Version = "0.2" | ||
| var Priority = 1 |
There was a problem hiding this comment.
what are those?
if that is the plugin version we should set it during build with build flags like we do for the backend
There was a problem hiding this comment.
The priority is meaningless since we are the only plugin server
The version is also just a thing you need to pass to the server. Not sure where it is being used
There was a problem hiding this comment.
since we are the only plugin server
maybe the user has its own plugins
Not sure where it is being used
Still I would put here the tag/commit hash from the build
FrimIdan
reviewed
Nov 11, 2021
FrimIdan
reviewed
Nov 11, 2021
FrimIdan
approved these changes
Nov 11, 2021
added 2 commits
November 11, 2021 15:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.