-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TARGWP20, TARGWP100 and TARGWP500 from third assessment report #28
Conversation
I'll take a look now @mikapfl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. A few typos and questions I think. Was indeed hard going through this with a pdf.
Is there a reason we're adding extra gases like "HGalden1040x"? Or is it just cause we've read them now, so may as well keep them?
Co-authored-by: Zeb Nicholls <[email protected]>
Co-authored-by: Zeb Nicholls <[email protected]>
Note: I didn't include |
Where is this not working? Should be a valid JS object or Python dictionary key, isn't it? |
It won't work as a normal unit in pint, i.e. in openscm-units, I think. |
Thanks for checking everything, Zeb! Very much appreciated. To be extra sure, I now did an alternative extraction using https://smallpdf.com/pdf-to-excel and targeted copy+pasting, which means I didn't have the chance to introduce typos using this way. I found two missing values for HFE356pcc3 (I was apparently also confused, it is super confusing because the gases are not really ordered alphabetically or something). Now I'm very confident that the values included here reflect what's in the official pdf. |
I just figured, if it is the pdf, let's add it now while we deal with this pdf and then never have to think about it again, hopefully. |
Maybe openscm-units should then just ignore it (it's very likely not handled by any SCM I guess). Not sure what level of completeness we have for other reports. If we include 'HGalden1040x' then why not '-(CF2)4CH(OH)-'? |
Ok, I added it and will deal with the fallout in openscm-units. I did the same amount of checking for it (extract via two different routes) so am confident in the values as well. |
Nice!
Hmph, but fair I guess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super, thank you!
Released as 0.10.0, thanks @mikapfl and @znicholls! |
0.10.1 - forgot to re-run |
Something which could be included in pre-commit or other CI 😉 |
We actually found a usage of global warming potentials from the third assessment report in the wild; therefore, we need them. Source is linked. I transferred it from pdf by hand (a mind-numbing exercise), so there might be errors. I'm willing to re-check tomorrow, but today it wouldn't make much sense.