Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong type for SAI_HA_SCOPE_ATTR_HA_SET_ID #2057

Closed
rupeshknvidia opened this issue Jul 29, 2024 · 2 comments · Fixed by #2068
Closed

wrong type for SAI_HA_SCOPE_ATTR_HA_SET_ID #2057

rupeshknvidia opened this issue Jul 29, 2024 · 2 comments · Fixed by #2068

Comments

@rupeshknvidia
Copy link

Attribute SAI_HA_SCOPE_ATTR_HA_SET_ID should be * @type sai_object_id_t , and not * @type sai_uint16_t

/**

  • @brief Attribute ID for HA scope
    */
    typedef enum _sai_ha_scope_attr_t
    {
    ...

    /**

    • @brief Action parameter HA set id
    • @type sai_uint16_t
    • @flags CREATE_AND_SET
    • @isvlan true
    • @default 0
      */
      SAI_HA_SCOPE_ATTR_HA_SET_ID = SAI_HA_SCOPE_ATTR_START,
@KrisNey-MSFT
Copy link

The auto-gen code missed this and put regular scalar. Object type is here:

[see here HA SET ID Attribute ](SAI/experimental/saitypesextensions.h at master · opencomputeproject/SAI (github.com))

This was referenced Aug 17, 2024
Merged
Merged
r12f pushed a commit to sonic-net/DASH that referenced this issue Aug 19, 2024
@jimmyzhai
[ha] Fix action param ha_set_id annotation (#615)
932720b 
Correct annotation tag typo (SalVal -> SaiVal) for action param
`ha_set_id`. It generates correct type of `ha_set_id` in ha spec
dash_ha.yaml and then in SAI header `saiexperimentaldashha.h`. In the
end it fixes the issue
opencomputeproject/SAI#2057.
@KrisNey-MSFT
Copy link

Close Issue after PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[dashha] Correct SAI_HA_SCOPE_ATTR_HA_SET_ID type jimmyzhai/SAI
2 participants
@KrisNey-MSFT @rupeshknvidia