Tunnel UDP SRC PORT security #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcudnik
requested changes
Mar 24, 2022
inc/saitunnel.h
Outdated
| * UDP source port outside of range defined for this tunnel, it | ||
| * will be dropped. | ||
| * | ||
| * @type sai_bool |
There was a problem hiding this comment.
Done, thanks
kcudnik
approved these changes
Apr 25, 2022
|
@JaiOCP , @ashutosh-agrawal - please help review. |
ashutosh-agrawal
approved these changes
May 5, 2022
| * @default false | ||
| * @validonly SAI_TUNNEL_ATTR_TYPE == SAI_TUNNEL_TYPE_VXLAN and SAI_TUNNEL_ATTR_VXLAN_UDP_SPORT_MODE == SAI_TUNNEL_VXLAN_UDP_SPORT_MODE_USER_DEFINED | ||
| */ | ||
| SAI_TUNNEL_ATTR_VXLAN_UDP_SPORT_SECURITY, |
There was a problem hiding this comment.
Please add either a new drop reason or a comment to include this in the existing tunnel decap drop reason.
|
@marian-pritsak - please resolve the DCO error, so that we can merge this, thanks. |
|
@marian-pritsak , please address DCO error. Thanks. |
|
@marian-pritsak - reminder to resolve DCO error |
Signed-off-by: Marian Pritsak <[email protected]>
kcudnik
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Question to community: Is this feature supported natively on your ASICs, or is it rather something that will have to be done with ACL?