Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CERTZ-1.1/1.2-gNSI Client Certificate Tests #2488

Open
wants to merge 76 commits into
base: main
Choose a base branch
from

Conversation

priyacj
Copy link

@priyacj priyacj commented Dec 14, 2023

Initial Commit of CERTZ-1.1 and CERTZ-1.2
Resolves #1990 and #1991

@priyacj priyacj requested review from a team as code owners December 14, 2023 08:04
Copy link

google-cla bot commented Dec 14, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@OpenConfigBot
Copy link

OpenConfigBot commented Dec 14, 2023

Pull Request Functional Test Report for #2488 / be654fa

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
CERTZ-1: gNSI Client Certificate Tests
Cisco 8000E status
CERTZ-1: gNSI Client Certificate Tests
Cisco XRd status
CERTZ-1: gNSI Client Certificate Tests
Juniper ncPTX status
CERTZ-1: gNSI Client Certificate Tests
Nokia SR Linux status
CERTZ-1: gNSI Client Certificate Tests
Openconfig Lemming status
CERTZ-1: gNSI Client Certificate Tests

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
CERTZ-1: gNSI Client Certificate Tests
Cisco 8808 status
CERTZ-1: gNSI Client Certificate Tests
Juniper PTX10008 status
CERTZ-1: gNSI Client Certificate Tests
Nokia 7250 IXR-10e status
CERTZ-1: gNSI Client Certificate Tests

Help

@coveralls
Copy link

coveralls commented Dec 14, 2023

Pull Request Test Coverage Report for Build 11900696376

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 11899140413: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

@mohanasm mohanasm added juniper-pr new-requirement-pr The PR introduces a new test scenario/requirement. labels Dec 14, 2023
5) Validate that the connection is properly torn down by the DUT.

## Protocol/RPC Parameter coverage

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this and the next 3 section headers are new, that appears to be basically the only changes to this file?

rpcs:
gnsi:
certz.v1.Certz.GetProfileList:
certz.v1.Certz.AddProfile:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apologies, this line and the next are 'new'.

I don't understand why this diff is 'whole file is new'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
juniper-pr new-requirement-pr The PR introduces a new test scenario/requirement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gNSI] certz-1.1
10 participants