-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transceiver-9: improving test flow #3462
Merged
ahsaanyousaf
merged 5 commits into
openconfig:main
from
karthikeya-remilla:laser_bias_test_changes
Sep 30, 2024
Merged
Transceiver-9: improving test flow #3462
ahsaanyousaf
merged 5 commits into
openconfig:main
from
karthikeya-remilla:laser_bias_test_changes
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11100370710Details
💛 - Coveralls |
ejbrever
reviewed
Sep 26, 2024
feature/platform/transceiver/tests/zr_laser_bias_current_test/zr_laser_bias_current_test.go
Outdated
Show resolved
Hide resolved
ejbrever
approved these changes
Sep 28, 2024
ahsaanyousaf
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in zr_laser_bias_test, we are streaming individual laser-current leaves in sample mode. namely - instant/avg/min/max values.
During the verification process, since these are pulled at different times, the avg value is sometimes not between the min and max values causing false test failure.
"The average is not between the maximum and minimum values Avg:232.50 Min:232.60 Max:232.60"
To better suit the test intent, we need to change the test to stream at the container level i.e
p1Stream := samplestream.New(t, dut1, component.OpticalChannel().LaserBiasCurrent().State(), 10*time.Second)
and then check the condition: min <= avg <= max for all the values "within" the container streamed at the same timestamp.
Test is passing with these changes.