Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transceiver-9: improving test flow #3462

Merged

Conversation

karthikeya-remilla
Copy link
Contributor

@karthikeya-remilla karthikeya-remilla commented Sep 26, 2024

Currently in zr_laser_bias_test, we are streaming individual laser-current leaves in sample mode. namely - instant/avg/min/max values.

During the verification process, since these are pulled at different times, the avg value is sometimes not between the min and max values causing false test failure.

"The average is not between the maximum and minimum values Avg:232.50 Min:232.60 Max:232.60"

To better suit the test intent, we need to change the test to stream at the container level i.e
p1Stream := samplestream.New(t, dut1, component.OpticalChannel().LaserBiasCurrent().State(), 10*time.Second)

and then check the condition: min <= avg <= max for all the values "within" the container streamed at the same timestamp.

Test is passing with these changes.

@karthikeya-remilla karthikeya-remilla requested a review from a team as a code owner September 26, 2024 18:48
@coveralls
Copy link

coveralls commented Sep 26, 2024

Pull Request Test Coverage Report for Build 11100370710

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 11097059185: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

@ahsaanyousaf ahsaanyousaf merged commit 756381c into openconfig:main Sep 30, 2024
13 checks passed
@karthikeya-remilla karthikeya-remilla deleted the laser_bias_test_changes branch October 3, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants