-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moved tests from experimental to feature #3469
Conversation
Pull Request Test Coverage Report for Build 11119333743Details
💛 - Coveralls |
a369216
to
133b24c
Compare
e2d07e5
to
e29956b
Compare
Please also update https://github.com/openconfig/featureprofiles/blob/main/CONTRIBUTING.md to remove the reference to the experimental folder. Thanks! |
@self-maurya i see the feature.textproto is been deleted. Can you add details on why this file is not needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start. Is there any reason not to move ALL of the tests out of the experimental folder?
The README files replace the intent of the feature.textproto files. The feature.textproto files are considered obsolete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.