Cisco logical channels #3470
Open
Cisco logical channels #3470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11111420277Details
💛 - Coveralls |
ejbrever
reviewed
Sep 30, 2024
| @@ -146,6 +148,25 @@ func validateEthernetChannelTelemetry(t *testing.T, otnChIdx, ethernetChIdx uint | |||
| want: oc.Assignment_AssignmentType_LOGICAL_CHANNEL.String(), | |||
| }, | |||
| } | |||
| var assignmentIndexTestcase struct { | |||
There was a problem hiding this comment.
can you define a struct type near the top:
type testcase struct {
desc string
got any
want any
}
Then around line 105, you can have:
tcs := []testcase {
}
Then here, this just changes to:
assignmentIndexTestCase := testcase{
desc: "Assignment: Index",
got: ec.GetAssignment(0).GetIndex(),
want: uint32(0),
})
if deviations.EthChannelAssignmentCiscoNumbering(dut) {
assignmentIndexTestCase.want = uint32(1)
}
tcs = append(tcs, assignmentIndexTestCase)
| want: oc.Assignment_AssignmentType_LOGICAL_CHANNEL.String(), | ||
| }, | ||
| } | ||
| var assignmentIndexTestcase struct { |
There was a problem hiding this comment.
please consider previous comment to avoid lots of redeclaring this struct definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for zr_logical_channels_test:
Note: ciscoOpticalChannelFormat := strings.ReplaceAll(opticalChannel, "/", "_") // Ex: OpticalChannel0_0_0_18
This is temporary line under the deviation till Cisco supports OpticalChannel in standard OpticalChannel0/0/0/18 format. Internal bug raised and in progress.