Add FORWARD node type and implementation #1919
alexmasigo.yml
on: pull_request
go
/
lint
22s
linter
/
Lint Code Base
2m 3s
Matrix: go / Build and Test
Annotations
10 errors and 3 warnings
|
go / lint:
x/wire/file/server/main.go#L73
exitAfterDefer: log.Fatalf will exit, and `defer frw1.Close()` will not run (gocritic)
|
|
go / lint:
x/wire/intf/client/main.go#L43
exitAfterDefer: log.Fatalf will exit, and `defer i0.Close()` will not run (gocritic)
|
|
go / lint:
x/wire/file/client/main.go#L43
exitAfterDefer: log.Fatalf will exit, and `defer frw1.Close()` will not run (gocritic)
|
|
go / lint:
topo/node/forward/forward.go#L85
commentFormatting: put a space between `//` and comment text (gocritic)
|
|
go / lint:
topo/node/forward/forward.go#L219
commentFormatting: put a space between `//` and comment text (gocritic)
|
|
go / lint:
x/wire/wire_test.go#L67
File is not `gofmt`-ed with `-s` (gofmt)
|
|
go / lint:
x/wire/intf/server/main.go#L73
exitAfterDefer: log.Fatalf will exit, and `defer i0.Close()` will not run (gocritic)
|
|
go / lint:
x/wire/forward/main.go#L150
exitAfterDefer: log.Fatalf will exit, and `defer conn.Close()` will not run (gocritic)
|
|
go / lint
issues found
|
|
go / Build and Test (1.21)
Process completed with exit code 1.
|
|
go / lint
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v4, golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
go / Build and Test (1.21)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
linter / Lint Code Base
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|