Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align kind + k8 versioning #389

Merged
merged 4 commits into from
Jun 29, 2023
Merged

Align kind + k8 versioning #389

merged 4 commits into from
Jun 29, 2023

Conversation

alexmasi
Copy link
Contributor

Use v0.26.6 kindest/node which is compatible with v0.20.0 of kind: https://github.com/kubernetes-sigs/kind/releases/tag/v0.20.0

Pin kind version in provisioner scripts

@github-actions
Copy link

github-actions bot commented Jun 23, 2023

Pull Request Test Coverage Report for Build 5407345298

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.061%

Changes Missing Coverage Covered Lines Changed/Added Lines %
deploy/deploy.go 0 1 0.0%
Totals Coverage Status
Change from base Build 5340408892: 0.0%
Covered Lines: 3673
Relevant Lines: 5560

💛 - Coveralls

@alexmasi
Copy link
Contributor Author

Will move presubmit to v0.20.0 in a follow up PR

@alexmasi
Copy link
Contributor Author

/gcbrun

@alexmasi alexmasi requested a review from guoshiuan June 23, 2023 23:39
@alexmasi
Copy link
Contributor Author

/gcbrun

1 similar comment
@alexmasi
Copy link
Contributor Author

/gcbrun

guoshiuan
guoshiuan previously approved these changes Jun 28, 2023
@alexmasi
Copy link
Contributor Author

/gcbrun

@alexmasi alexmasi changed the title kindv0.20.0+k8v0.26.6 Align kind + k8 versioning Jun 29, 2023
@alexmasi
Copy link
Contributor Author

Having some issues with kind 20. Changing this PR to do the following:

  • pin the kind version to 19 in the image provisioner scripts
  • use kindest/node 0.26.0 in all deployment configs
  • use k8 0.26 in all code dependencies
  • use k8 0.27 for the client (kubectl)
  • require at least kind 17 in all deployment configs, however 19 is the latest version known to work

This combination is known to work with KNE for all supported vendor images.

@alexmasi alexmasi merged commit 55a815d into main Jun 29, 2023
@alexmasi alexmasi deleted the vers branch June 29, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants