Add config management with viper #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
Pull Request Test Coverage Report for Build 5481146700
💛 - Coveralls |
bormanp
reviewed
Jul 6, 2023
| d, err := newDeployment(args[0], false) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if err := d.Deploy(cmd.Context(), kubecfg); err != nil { | ||
| d.Progress = viper.GetBool("progress") | ||
| if err := d.Deploy(cmd.Context(), viper.GetString("kubecfg")); err != nil { |
There was a problem hiding this comment.
What happens if the GetString returns ""? It would be nice if this (and possibly other) values could be sanity checked prior to running these functions as then you don't have to worry about checking the values.
There was a problem hiding this comment.
this is the same behavior as the current implementation, if the flag was the empty string then the function call would handle it as before. in the case of kubecfg the empty string is completely valid as an argument if the user wants to fallback to the in cluster config.
kne_cli/main.go
Outdated
| @@ -45,7 +45,8 @@ func main() { | |||
| } | |||
| } | |||
| flags.Import() | |||
| err := cmd.ExecuteContext(context.Background()) | |||
| root := cmd.New() | |||
| err := root.ExecuteContext(context.Background()) | |||
There was a problem hiding this comment.
You could just say cmd.New().ExecuteContext(...)
|
/gcbrun |
bormanp
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.