EmitJSON/ConstructJSON/Marshal7951 support for structs containing ordered maps. #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wenovus
commented
Apr 28, 2023
•
wenovus
commented
Initially I made the choice to use a non-pointer so that the user would not need to initialize this field before using it. The advantage is all methods can hang off of the type rather than needing methods to hang off the parent type in order to nil-check and initialize. However, this creates problems that a pointer field solves: 1. Avoid needing value-receivers in order to make the field satisfy certain interfaces (e.g. ygot.GoStruct). Mixing receiver types is confusing for the reader. 2. Helps avoid awkward reflection code that need to access the pointer receiver methods since `CanAddr()=false` for non-pointer objects: https://go.dev/play/p/5vYVVUS-GfD 3. Users of ygot are used to declaring every struct as pointers, so using pointers makes things congruent with existing generated code.
…containing ordered maps.
Note: ordered maps themselves cannot be processed by these functions.
Ideally Go supports type constraints of unions of interfaces but it
doesn't, and I think it is too early to change the input parameters of
these functions from ygot.GoStruct -> interface{} or add even more
methods to achieve what ygnmi does with the query types -- which would
bloat the generated code for a small gain which might not be so useful
right now.
|
Changes Unknown when pulling afe4ab1 on ordered-map-emitjson into ** on master**. |
wenovus
changed the title
DanG100
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.