-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spec: Consider removing references to UUID #13
Comments
+1 |
@stevvooe is this true? or put another way what is the likelihood that popular legacy clients are going to throw an exception if the id does not fit some expected UUID form via regex validation? |
FWIW GCR relies on that being true. |
@jonjohnsonjr are you saying GCR relies on the string of UUID not being a strict uuid? |
Yep, that's correct. We haven't had any issue with clients expecting an actual uuid (as far as I know), since clients just treat the "uuid" as an opaque string. |
naming constraints :) |
the behavior previously described as `UUID` is really a session ID. For implementations with existing behavior this is a nop, but going forward the header `Blob-Upload-Session-ID` is more clear than `Docker-Upload-UUID`. Fixes opencontainers#13 Signed-off-by: Vincent Batts <[email protected]>
PTAL @ #76 |
the behavior previously described as `UUID` is really a session ID. For implementations with existing behavior this is a nop, but going forward the header `Blob-Upload-Session-ID` is more clear than `Docker-Upload-UUID`. Fixes opencontainers#13 Signed-off-by: Vincent Batts <[email protected]>
the behavior previously described as `UUID` is really a session ID. For implementations with existing behavior this is a nop, but going forward the header `Blob-Upload-Session-ID` is more clear than `Docker-Upload-UUID`. Fixes opencontainers#13 Signed-off-by: Vincent Batts <[email protected]>
# This is the 1st commit message: spec: session_id is clearer than UUID the behavior previously described as `UUID` is really a session ID. For implementations with existing behavior this is a nop, but going forward the header `Blob-Upload-Session-ID` is more clear than `Docker-Upload-UUID`. Fixes opencontainers#13 Signed-off-by: Vincent Batts <[email protected]> # This is the commit message #2: Create several tests for compliance # This is the commit message #3: set debug option on, added hostname env variable # This is the commit message #4: Add Tags tests # This is the commit message #5: added new tests # This is the commit message #6: added reference file for a correctly formatted manifest # This is the commit message opencontainers#7: updated with more tests; note that some aren't working properly # This is the commit message opencontainers#8: Add tests for chunked uploading * Roll back reggie * Tests working again * Working tests for chunked uploads * Started running it against Docker opensource registry
Defining terms
The spec constantly refers to UUID that reference a given upload e.g. the
Docker-Upload-UUID
header.However, there's no real reason this needs to be a UUID, it's just a reference number or ID (as noted in the spec itself "While the uuid parameter may be an actual UUID, this proposal imposes no constraints on the format and clients should never impose any"). Could it be changed to just
id
orrefid
or some such?The text was updated successfully, but these errors were encountered: