Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec: Consider removing references to UUID #13

Closed
amouat opened this issue May 17, 2018 · 7 comments · Fixed by #76
Closed

spec: Consider removing references to UUID #13

amouat opened this issue May 17, 2018 · 7 comments · Fixed by #76

Comments

@amouat
Copy link
Contributor

amouat commented May 17, 2018 •
edited
Loading

The spec constantly refers to UUID that reference a given upload e.g. the Docker-Upload-UUID header.

However, there's no real reason this needs to be a UUID, it's just a reference number or ID (as noted in the spec itself "While the uuid parameter may be an actual UUID, this proposal imposes no constraints on the format and clients should never impose any"). Could it be changed to just id or refid or some such?
@jzelinskie
Copy link
Member

jzelinskie commented May 25, 2018 •
edited
Loading

+1
It just needs to be a unique value for the upload.

@bsatlas bsatlas mentioned this issue Nov 24, 2018
Closed
@mikebrow
Copy link
Member

@stevvooe is this true? or put another way what is the likelihood that popular legacy clients are going to throw an exception if the id does not fit some expected UUID form via regex validation?

@jonjohnsonjr
Copy link
Contributor

FWIW GCR relies on that being true.

@vbatts
Copy link
Member

vbatts commented Jan 29, 2019

@jonjohnsonjr are you saying GCR relies on the string of UUID not being a strict uuid?

@jonjohnsonjr
Copy link
Contributor

Yep, that's correct. We haven't had any issue with clients expecting an actual uuid (as far as I know), since clients just treat the "uuid" as an opaque string.

@mikebrow
Copy link
Member

naming constraints :)

vbatts added a commit to vbatts/oci-distribution-spec that referenced this issue Dec 20, 2019
@vbatts
spec: session_id is clearer than UUID
0a84d1c 
the behavior previously described as `UUID` is really a session ID.
For implementations with existing behavior this is a nop, but going
forward the header `Blob-Upload-Session-ID` is more clear than
`Docker-Upload-UUID`.

Fixes opencontainers#13

Signed-off-by: Vincent Batts <[email protected]>
@vbatts vbatts mentioned this issue Dec 20, 2019
Merged
@vbatts
Copy link
Member

vbatts commented Dec 20, 2019

PTAL @ #76

vbatts added a commit to vbatts/oci-distribution-spec that referenced this issue Dec 20, 2019
@vbatts
spec: session_id is clearer than UUID
4a02b83 
the behavior previously described as `UUID` is really a session ID.
For implementations with existing behavior this is a nop, but going
forward the header `Blob-Upload-Session-ID` is more clear than
`Docker-Upload-UUID`.

Fixes opencontainers#13

Signed-off-by: Vincent Batts <[email protected]>
vbatts added a commit to vbatts/oci-distribution-spec that referenced this issue Dec 20, 2019
@vbatts
spec: session_id is clearer than UUID
35c06bd 
the behavior previously described as `UUID` is really a session ID.
For implementations with existing behavior this is a nop, but going
forward the header `Blob-Upload-Session-ID` is more clear than
`Docker-Upload-UUID`.

Fixes opencontainers#13

Signed-off-by: Vincent Batts <[email protected]>
pmengelbert pushed a commit to bloodorangeio/distribution-spec that referenced this issue Jan 16, 2020
@vbatts @pmengelbert
# This is a combination of 8 commits.
6b631b9 
# This is the 1st commit message:

spec: session_id is clearer than UUID

the behavior previously described as `UUID` is really a session ID.
For implementations with existing behavior this is a nop, but going
forward the header `Blob-Upload-Session-ID` is more clear than
`Docker-Upload-UUID`.

Fixes opencontainers#13

Signed-off-by: Vincent Batts <[email protected]>

# This is the commit message #2:

Create several tests for compliance

# This is the commit message #3:

set debug option on, added hostname env variable

# This is the commit message #4:

Add Tags tests

# This is the commit message #5:

added new tests

# This is the commit message #6:

added reference file for a correctly formatted manifest

# This is the commit message opencontainers#7:

updated with more tests; note that some aren't working properly

# This is the commit message opencontainers#8:

Add tests for chunked uploading

* Roll back reggie
* Tests working again
* Working tests for chunked uploads
* Started running it against Docker opensource registry
sudo-bmitch pushed a commit to sudo-bmitch/distribution-spec that referenced this issue Aug 24, 2022
@jdolitsky
Merge pull request opencontainers#13 from sudo-bmitch/playground-pr
d68e91d 
Defining terms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

spec: session_id is clearer than UUID vbatts/oci-distribution-spec
5 participants
@vbatts @amouat @jzelinskie @mikebrow @jonjohnsonjr