Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conformance: move Dockerfile to conformance directory #99

Closed
jdolitsky opened this issue Feb 12, 2020 · 0 comments · Fixed by #104
Closed

conformance: move Dockerfile to conformance directory #99

jdolitsky opened this issue Feb 12, 2020 · 0 comments · Fixed by #104

Comments

@jdolitsky
Copy link
Member

See #98 (review)
@jdolitsky jdolitsky mentioned this issue Feb 12, 2020
Merged
@jdolitsky jdolitsky mentioned this issue Feb 26, 2020
Closed
jdolitsky added a commit to bloodorangeio/distribution-spec that referenced this issue Feb 28, 2020
@jdolitsky
Move Dockerfile to conformance directory
263eb29 
In order to prevent confusion about the purpose of the Dockerfile,
move it into conformance directory where it is more appropriate.

Also remove dependency on Makefile, and instead using build args
to pass along the test version that is visible in report.html.

Resolves opencontainers#99.

Signed-off-by: Josh Dolitsky <[email protected]>
@jdolitsky jdolitsky mentioned this issue Feb 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move Dockerfile to conformance directory bloodorangeio/distribution-spec
1 participant
@jdolitsky