-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document manifest size limit recommendation #293
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -402,6 +402,10 @@ The `<location>` is a pullable manifest URL. | |||||||
|
||||||||
An attempt to pull a nonexistent repository MUST return response code `404 Not Found` | ||||||||
|
||||||||
A registry SHOULD enforce some limit on the maximum manifest size that it can accept. | ||||||||
A registry that enforces this limit SHOULD respond to a request to push a manifest over this limit with a response code `413 Payload Too Large`. | ||||||||
Client and registry implementations SHOULD expect to be able to support manifest pushes of at least 4 megabytes. | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd suggest splitting this into two lines, one for clients, and one for registries:
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe something like:
FWIW, if quay has a 1MB limit, I would lean toward 1MB as the recommendation. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The wording from @jonjohnsonjr is more clear. |
||||||||
|
||||||||
#### Content Discovery | ||||||||
|
||||||||
Currently, the only functionality provided by this workflow is the ability to discover tags. | ||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this is recommended for public registries, I can see a case for private registries not wanting to implement this.