conformance: make references tests part of content discovery workflow #430
Conversation
jdolitsky
force-pushed
the
conformance-update
branch
from
f458549
to
8bd7ce2
Compare
Signed-off-by: Josh Dolitsky <[email protected]>
jdolitsky
force-pushed
the
conformance-update
branch
from
8bd7ce2
to
26c0530
Compare
jdolitsky
changed the title
jdolitsky
requested review from
dmcgowan,
jzelinskie,
jonjohnsonjr,
mikebrow,
stevvooe,
sudo-bmitch and
vbatts
as code owners
| req = client.NewRequest(reggie.PUT, "/v2/<name>/manifests/<reference>", | ||
| reggie.WithReference(refsManifestALayerArtifactDigest)). | ||
| SetHeader("Content-Type", "application/vnd.oci.image.manifest.v1+json"). | ||
| SetBody(refsManifestALayerArtifactContent) |
There was a problem hiding this comment.
Hi @jdolitsky
Looking at this test @peusebiu and I noticed refsManifestALayerArtifactContent actually contains a reference to layer testRefBlobB (see https://github.com/opencontainers/distribution-spec/blob/main/conformance/setup.go#L396), which is not yet uploaded to the registry.
My understanding of the push specifications is that layer blobs should be pushed by the client before the manifest.
If the server decides to reject them, it remains fully compliant. So why would the test check the server accepts this upload.
We're not sure if this is by design of the test, or a bug, as testRefBlobB is uploaded later at line 198.
On the other hand the code in setup.go is strange, maybe testRefBlobA should have been reference there in setup.go at line 396
There was a problem hiding this comment.
Yes, I defer to Ram. In this PR I tried to just copy-paste his work
…opencontainers#430) Signed-off-by: Josh Dolitsky <[email protected]>
No description provided.