Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make test broken on master #84

Closed
vbatts opened this issue May 23, 2016 · 8 comments
Closed

make test broken on master #84

vbatts opened this issue May 23, 2016 · 8 comments

Comments

@vbatts
Copy link
Member

vbatts commented May 23, 2016

https://travis-ci.org/opencontainers/image-spec/builds/132403826

0aafcef

@s-urbaniak
Copy link
Collaborator

wat, I cannot reproduce this here, also it wasn't present on the PR, do you mind rebuilding?
@stevvooe any idea?

@vbatts
Copy link
Member Author

vbatts commented May 23, 2016

I was able to reproduce on master, on my desktop

On Mon, May 23, 2016, 18:29 Sergiusz Urbaniak [email protected]
wrote:

wat, I cannot reproduce this here, also it wasn't present on the PR, do
you mind rebuilding?
@stevvooe https://github.com/stevvooe any idea?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#84 (comment)

@s-urbaniak
Copy link
Collaborator

ok, I am able to reproduce it locally with a fresh GOPATH. so apparently blackfriday changed upstream, time to do vendoring.

I'll dig into it.

@s-urbaniak
Copy link
Collaborator

correction: it was transiently introduced by pkg/errors#27

@stevvooe
Copy link
Contributor

Wow. An error value that cannot be compared... what a minefield.

Filed pkg/errors#29.

@s-urbaniak
Copy link
Collaborator

ok, pkg/errors is fixed upstream, that was quick :-) "Works on my machine" with a fresh gopath.

@stevvooe
Copy link
Contributor

@s-urbaniak Great! Kicking off a new build. Hopefully it works.

Do we close this and open a vendoring issue? I'd rather not go to vendoring quite yet...

@stevvooe
Copy link
Contributor

Build recovered. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants