Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum criteria for new maintainers? #912

Closed
jdolitsky opened this issue May 4, 2022 · 7 comments · Fixed by #919
Closed

Minimum criteria for new maintainers? #912

jdolitsky opened this issue May 4, 2022 · 7 comments · Fixed by #919

Comments

@jdolitsky
Copy link
Member

Is there any minimum criteria/qualifications for a new maintainer to be added to this project?

For example:

  • number of community calls attended
  • involvement in mailing list
  • involvement in WG efforts
  • number of commits
  • comment history

?

@sudo-bmitch
Copy link
Contributor

For myself, I held off saying I'd be interested in being a maintainer until I had gone through the process of submitting a PR since I feel that helps understand the project and the other side of what maintainers do. That's my personal criteria, and I think exceptions make sense, particularly for anyone that participates in PRs without authoring the commit.

I do think it would be useful for OCI to consider the various roles in the spec and try to seek out maintainers to represent those roles. E.g. major SaaS provider, self hosted vendor, runtime author, and other client tooling each come to mind.

@jdolitsky
Copy link
Member Author

cc @rnjudge who had some previous thoughts/questions here

@dlorenc
Copy link

dlorenc commented May 5, 2022

That's my personal criteria, and I think exceptions make sense, particularly for anyone that participates in PRs without authoring the commit.

Agree that this makes sense normally. Right now it's tough because we can't get any changes submitted because of the lack of maintainers though.

@rnjudge
Copy link

rnjudge commented May 5, 2022

Thanks for the tag @jdolitsky! My two cents:

At a minimum:

  • Participation in the weekly community meetings
  • Involvement in mailing list when applicable (hard to quantify this)
  • Involvement in WG efforts (also hard to quantify this beyond showing up to general meetings)
  • Minimum time involvement in the community (i.e. 3 months, 6 months?)

I'm not sure you want to quantify a specific number of commits or comments. There's not really a lot of commits going into this project all the time so if someone wanted to be a new maintainer it might be hard to get them onboard with a minimum number of commits required. I agree that they should at least have opened or co-authored a PR though. At least one seems reasonable. It also seems reasonable to expect that maintainers are reviewing PRs and providing feedback for issues.

I would also consider how many maintainers from each company there is. Typically you want a fairly even representation among companies. Assigning a number to this depends on how many maintainers there will be. Is there going to be a set number or is is it just however many fit the criteria? Other things to consider: are new maintainers nominated/sponsored by existing maintainers or can someone self-nominate?

It might also be good to have a list of expectations for maintainers in addition to minimum requirements since being a maintainer requires active and ongoing work.

@AkihiroSuda
Copy link
Member

AkihiroSuda commented May 10, 2022

At a minimum:

  • Participation in the weekly community meetings

Sounds exclusive to timezone minorities 😞
I'm feeling that the FLOSS community should rather focus on asynchronous communications such as GitHub and Slack.

@jdolitsky
Copy link
Member Author

I've added this to the call agenda for this week. Will be sure to keep in mind the timezone issue @AkihiroSuda

@jdolitsky
Copy link
Member Author

Consensus on todays call appeared to be:

nishakm added a commit to nishakm/image-spec that referenced this issue May 16, 2022
This is a PR template to propose adding new maintainers

Fixes opencontainers#912

Signed-off-by: nisha <[email protected]>
nishakm added a commit to nishakm/image-spec that referenced this issue May 16, 2022
This is a PR template to propose adding new maintainers

Fixes opencontainers#912

Signed-off-by: nisha <[email protected]>
nishakm added a commit to nishakm/image-spec that referenced this issue May 26, 2022
This is a PR template to propose adding new maintainers

Fixes opencontainers#912

Signed-off-by: nisha <[email protected]>
sajayantony pushed a commit to sajayantony/image-spec that referenced this issue Aug 5, 2022
This is a PR template to propose adding new maintainers

Fixes opencontainers#912

Signed-off-by: nisha <[email protected]>
jdolitsky pushed a commit to oci-playground/image-spec that referenced this issue Aug 9, 2022
This is a PR template to propose adding new maintainers

Fixes opencontainers#912

Signed-off-by: nisha <[email protected]>
sudo-bmitch pushed a commit to sudo-bmitch/image-spec that referenced this issue Sep 25, 2022
This is a PR template to propose adding new maintainers

Fixes opencontainers#912

Signed-off-by: nisha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants