Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VERSION: update to 1.0.0-rc9 #2134

Merged
merged 2 commits into from
Oct 5, 2019
Merged

VERSION: update to 1.0.0-rc9 #2134

merged 2 commits into from
Oct 5, 2019

Conversation

cyphar
Copy link
Member

@cyphar cyphar commented Oct 1, 2019

Signed-off-by: Aleksa Sarai [email protected]

@TomSweeneyRedHat
Copy link

LGTM

@crosbymichael
Copy link
Member

crosbymichael commented Oct 1, 2019 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

thaJeztah
thaJeztah approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not a maintainer)

@hqhq
Copy link
Contributor

hqhq commented Oct 5, 2019 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@cyphar
Copy link
Member Author

cyphar commented Oct 5, 2019

Still waiting for one of @dqminh or @mrunalp to make the 2/3rd requirement (which we definitely need to drop once we 1.0 -- this is getting a little bit silly).

@mrunalp
Copy link
Contributor

mrunalp commented Oct 5, 2019 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@cyphar
Copy link
Member Author

cyphar commented Oct 5, 2019

Good enough for me. 😉

@mrunalp
Copy link
Contributor

mrunalp commented Oct 5, 2019 via email

@cyphar cyphar closed this in c1485a1 Oct 5, 2019
@cyphar cyphar merged commit 2111613 into opencontainers:master Oct 5, 2019
@cyphar cyphar deleted the release-rc9 branch October 5, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cyphar @TomSweeneyRedHat @crosbymichael @hqhq @mrunalp @thaJeztah