[1.1] Add go 1.21 to CI #3976
Merged
[1.1] Add go 1.21 to CI #3976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kir Kolyshkin <[email protected]>
[XXX 1.1 note: the above subject and the rest of the commit message is the original description from the cherry-picked commit which talks about 1.19 -- while in fact it is now 1.20.] This variable is used in curl to download a go release, so we are using the initial Go 1.19 release in Cirrus CI, not the latest Go 1.19.x release. From the CI perspective, it makes more sense to use the latest release. Add some jq magic to extract the latest minor release information from the download page, and use it. This brings Cirrus CI jobs logic in line with all the others (GHA, Dockerfile), where by 1.20 we actually mean "latest 1.20.x". Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit 873d7bb) Signed-off-by: Kir Kolyshkin <[email protected]>
1. Do not use echo, as this results in lines like this: ... echo "-----" ----- ... 2. Move "cat /proc/cpuinfo" to be the last one, as the output is usually very long. 3. Add "go version" to CentOS jobs. Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit fd1a79f) Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
For "make integration", the tests are run inside a Docker/Podman container. Problem is, if cgroup v2 is used, the in-container /sys/fs/cgroup/cgroup.subtree_control is empty. The added script, used as Docker entrypoint, moves the current process into a sub-cgroup, and then adds all controllers in top-level cgroup.subtree_control. Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit cfc801b) Signed-off-by: Kir Kolyshkin <[email protected]>
Split the test into two -- for fs and systemd cgroup managers, and only run the second one if systemd is available. Prevents the following failure during `make unittest`: > === RUN TestNilResources > manager_test.go:27: systemd not running on this host, cannot use systemd cgroups manager > --- FAIL: TestNilResources (0.22s) Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit 962019d) Signed-off-by: Kir Kolyshkin <[email protected]>
A few cases relied on the fact that systemd is used, and thus /sys/fs/cgroup/user.slice is available. Guess what, in case of "make unittest" it might not be. Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit 5c6b334) Signed-off-by: Kir Kolyshkin <[email protected]>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3 to 4. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v3...v4) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> (cherry picked from commit e3cf217) Signed-off-by: Kir Kolyshkin <[email protected]>
|
I've restarted cirrus tasks |
Since commit e3cf217 actions/setup-go@v4 uses caching implicitly, so it is no longer required. Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit 083e978) Signed-off-by: Kir Kolyshkin <[email protected]>
Since commit e3cf217 actions/setup-go@v4 uses caching implicitly, and olangci/golangci-lint-action also uses caching. These two caches clash, resulting in multiple warnings in CI logs. The official golangci-lint-action solution is to disable caching for setup-go job (see [1]). Do the same. [1] golangci/golangci-lint-action#704 Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit 62cc13e) Signed-off-by: Kir Kolyshkin <[email protected]>
The exception was fixed by polyfloyd/go-errorlint#12 which eventually made its way into golangci-lint. Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit 98317c1) Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
1.1-go-1.21-ci
branch
from
25ab7ab
to
bdbfe04
Compare
AkihiroSuda
approved these changes
Aug 10, 2023
AkihiroSuda
reviewed
Aug 10, 2023
| @@ -21,7 +21,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| go-version: [1.17.x, 1.19.x, 1.20.x] | |||
| go-version: [1.17.x, 1.20.x, 1.21.x] | |||
There was a problem hiding this comment.
I'm not sure. The original plan was to maintain support for older releases in a stable branch, but since this branch ended up a very long lived one, we had to drop 1.16 support in runc 1.1.6 because of #3817.
Let it stay for now (I hope we'll release 1.2.0 soon and more-or-less forget about 1.1.x)
mrunalp
approved these changes
Aug 10, 2023
This was referenced Aug 10, 2023
Merged
This was referenced Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial backport of the following PRs:
The main theme is adding Go 1.21, plus some CI fixes.