Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/gha: add job timeouts #3984

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

kolyshkin
Copy link
Contributor

The default timeout is 360 minutes, which is way long for these jobs. If the CI (or a test) has stuck, we'd better know about it earlier than in 6 hours.

Set the timeouts for some [relatively] long running jobs conservatively:

  • test and release jobs usually take ~10 minutes;
  • lint job takes 1 minute (but can be a few times slower when we switch Go or golangci-lint version);
  • cross-386 job takes about 2 minutes;
  • the rest is seconds (and I am lazy to set timeouts everywhere).

Inspired by #3953/#3982.

The default timeout is 360 minutes, which is way long for these jobs.
If the CI (or a test) has stuck, we'd better know about it earlier than
in 6 hours.

Set the timeouts for some [relatively] long running jobs conservatively:
 - test and release jobs usually take ~10 minutes;
 - lint job takes 1 minute (but can be a few times slower when we switch
   Go or golangci-lint version);
 - cross-386 job takes about 2 minutes;
 - the rest is seconds (and I am lazy to set timeouts everywhere).

Signed-off-by: Kir Kolyshkin <[email protected]>
@lifubang
Copy link
Member

  • and I am lazy to set timeouts everywhere

If there is a configuration item in jobs to set the default timeout minutes for all jobs, it will be better. But there is no. 😿

@lifubang lifubang merged commit ff8c4c7 into opencontainers:main Aug 17, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants