-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.2.1 #4500
Release v1.2.1 #4500
Conversation
Grrr, codespell is failing because it wants to correct spanish, that is written properly -.-. Changed it to another phrase now. |
ceb3929
to
536a486
Compare
cc235d6
to
fb01b7a
Compare
0db3570
to
56053ab
Compare
56053ab
to
208b422
Compare
Updated the release date for TODAY, as @AkihiroSuda asked |
Also, please feel free to push to this branch if you want to release today (maintainers can push). It's quite late here, I won't be online much longer. |
208b422
to
827c909
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll prep the release.
You forgot to update |
Signed-off-by: Rodrigo Campos <[email protected]> Signed-off-by: Kir Kolyshkin <[email protected]> Signed-off-by: Aleksa Sarai <[email protected]>
Signed-off-by: Rodrigo Campos <[email protected]>
827c909
to
5fc3558
Compare
Congratulations on the release! Just two comments from reading the release notes
The release notes don't have the "Fixed" header, and so the sentence starting with "Became root" is pretty hard to make sense of. Also, the current release notes say (my emphasis)
which should probably say "opt-in", c.f. the following from the OP
|
@h-vetinari Fixed. Turns out I can't proofread properly late at night... 😅 |
I propose to release 1.2.1
early next weekTODAY (see comment asking for it here: #4500 (review)). containerd needs the fixes here to properly update to the 1.2.x branch.[1.2.1] - 2024-11-05
Fixed
won't have permissions to configure some mounts when running under
SELinux and runc is not creating the user namespace. (containerd's
TestPodUserNS
fails with runc v1.2 (succeeds with crun) on SELinux distro:setxattr /[...]/dev/mqueue: operation not permitted
#4466, [1.2] libct/nsenter: become root after joining userns #4477)Changed
golang.org/x/sys/execabs
from go.mod. ([1.2] libct: rm x/sys/execabs usage #4480)the new protection mechanism added in v1.2.0. Note that runc-dmz was only
available only in the 1.2.0 release and required to set an environment variable
to opt-in. ([1.2] drop runc-dmz solution according to overlay solution #4488)
script/check-config.sh
script now checks for overlayfs support. ([1.2] Post overlay addition and dmz removal nits #4494)specific value. ([1.2] runc update: fix updating swap for cgroup v2 #4501)