Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.1.0-rc.2 #1192

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Mar 28, 2023

Call for vote: https://groups.google.com/a/opencontainers.org/g/dev/c/fnCiFoXBsiI/m/fbbmbs19EQAJ
Closes Tue Apr 4 03:33:57 AM UTC 2023


After releasing v1.1.0-rc.2, I propose feature-freezing the main branch until releasing v1.1.0 GA, with an exception for PRs that were opened before proposing v1.1.0-rc.2. (e.g., #1188 #1190 #1191)


Changes (v1.0.2→v1.1.0-rc.1)

See #1175

Changes (v1.1.0-rc.1→v1.1.0-rc.2)

Additions

Minor fixes and documentation

Copy link
Member

@vbatts vbatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe
Copy link
Member

I think we also need: #1193

@AkihiroSuda
Copy link
Member Author

I think we also need: #1193

Updated PR to include this

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hqhq hqhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda
Copy link
Member Author

@vbatts @kolyshkin May I assume this one still LGTY?

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Through 2ee82c5 (2023-04-05)

Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda
Copy link
Member Author

Rebased to include:

@AkihiroSuda
Copy link
Member Author

@opencontainers/runtime-spec-maintainers Please vote (if you haven't) 🙏

@utam0k
Copy link
Member

utam0k commented Apr 6, 2023

I can't wait to release the latest version 🚀

@AkihiroSuda
Copy link
Member Author

@opencontainers/runtime-spec-maintainers We need 7 LGTMs to make this release. (Currently we have 4)

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dqminh
Copy link
Contributor

dqminh commented Apr 13, 2023

LGTM

@thaJeztah
Copy link
Member

Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AkihiroSuda
Copy link
Member Author

  • Voters: 10 (11 maintainers minus myself)
  • Actual votes: 7
  • Approvals: 7

Let me merge this and make a release

@AkihiroSuda AkihiroSuda merged commit 33f13d1 into opencontainers:main Apr 17, 2023
@AkihiroSuda AkihiroSuda mentioned this pull request May 22, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants