ci: Add a github actions workflow for lint #1257
Open
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utam0k
requested review from
AkihiroSuda,
crosbymichael,
cyphar,
dqminh,
giuseppe,
hqhq,
kolyshkin,
mrunalp,
thaJeztah and
tianon
as code owners
AkihiroSuda
reviewed
Jun 16, 2024
utam0k
force-pushed
the
ci-lint
branch
2 times, most recently
from
9a08129
to
be9bc85
Compare
AkihiroSuda
approved these changes
Jun 16, 2024
kolyshkin
reviewed
Jun 16, 2024
.github/workflows/lint.yml
Outdated
Comment on lines
31
to
36
| if [[ -n $(git status --porcelain) ]]; then | ||
| echo "There are unformatted files." | ||
| exit 1 | ||
| else | ||
| echo "All files are properly formatted." | ||
| fi |
There was a problem hiding this comment.
Perhaps it's better to replace this with git diff --exit-code, which will show what's wrong and make the CI fail, too.
There was a problem hiding this comment.
Signed-off-by: utam0k <[email protected]>
Jpjames1
approved these changes
Oct 30, 2024
|
@kolyshkin PTAL 🙏 |
kolyshkin
reviewed
Oct 30, 2024
Comment on lines
+7
to
+10
| runs-on: ubuntu-latest | ||
| env: | ||
| # We need jq +1.7 because of jqlang/jq#1741. | ||
| JQ_VERSION: '1.7' |
There was a problem hiding this comment.
According to https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md, ubuntu-24.04 has jq 1.7.1-3build1, so we can just use ubuntu-24.04 here and skip jq upgrade step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prevent like #1255
It works fine: https://github.com/utam0k/runtime-spec/actions/runs/9534058439/job/26278029545