Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for Yosemite #14

Merged
merged 3 commits into from
Jul 26, 2016
Merged

Update README for Yosemite #14

merged 3 commits into from
Jul 26, 2016

Conversation

pburkholder
Copy link
Contributor

I don't know if all this is needed for ElCapitan

I don't know if all this is needed for ElCapitan
export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig
go get github.com/moovweb/gokogiri
go get github.com/opencontrol/fedramp-templater
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Mind splitting "install the dependencies" from "install the tool"? Also, mind adding bash to the syntax blocks for highlighting?

@afeld
Copy link
Member

afeld commented Jul 14, 2016

Very helpful, thanks! Fixes #12.

brew install libxml2
ln -s /usr/local/Cellar/libxml2/2.9.4/lib/pkgconfig/libxml-2.0.pc /usr/local/lib/pkgconfig/libxml-2.0.pc
export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig
go get github.com/moovweb/gokogiri
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use a fork, and this shouldn't be necessary anyway, since all the dependencies are vendored.

@afeld
Copy link
Member

afeld commented Jul 20, 2016

Note that with upgrading to Go 1.6.3 (or something else) on El Capitan, I needed to

export PKG_CONFIG_PATH=/usr/local/opt/libxml2/lib/pkgconfig

per Homebrew/legacy-homebrew#19030 (comment).

@afeld
Copy link
Member

afeld commented Jul 20, 2016

Regardless of what the instructions actually are, my preference would be to add them to https://github.com/jbowtie/gokogiri as a pull request and link there, so they stay up-to-date and are more centralized.

@jcscottiii
Copy link
Member

jcscottiii commented Jul 20, 2016

I remember earlier trying to get this to work (on El Capitan) and it wouldn't (this is back in the beginning of this project). I just pulled down the latest code and the build just works. I even uninstalled libxml2 and it works. The tests work too.

Per comments, move ugly details downstream.
@pburkholder
Copy link
Contributor Author

@afeld @jcscottiii Yup, moved install questions over to the Gokogiri end... How now?

@afeld afeld merged commit 3bd9c52 into master Jul 26, 2016
@afeld afeld deleted the pburkholder-patch-1 branch July 26, 2016 02:48
@afeld
Copy link
Member

afeld commented Jul 26, 2016

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants