Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: base on GDAL 3.8.0+space savings #544

Merged
merged 6 commits into from
Nov 16, 2023

Conversation

pjonsson
Copy link
Contributor

Base the image on GDAL 3.8.0, combine some layers, and run apt-get upgrade to get package updates.

This PR is on top of #543, but otherwise not related to those changes.

Disable failing tests with a FIXME
so they are easy to find at a later
stage.
This updates the base container from
Ubuntu 20.04 to Ubuntu 22.04.

Combined with the update of flask,
Trivy now makes a lot less noise.

Fixes opendatacube#537
This avoids installing a lot of packages
so the image size is kept small.
Make sure the latest security updates
from Ubuntu are brought in when building
the image.
Docker creates one layer per RUN statement,
so combine consecutive RUN statements into
a single statement.
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ccf1f3a) 86.33% compared to head (69b1643) 85.88%.
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #544      +/-   ##
===========================================
- Coverage    86.33%   85.88%   -0.46%     
===========================================
  Files           26       26              
  Lines         3455     3457       +2     
===========================================
- Hits          2983     2969      -14     
- Misses         472      488      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@omad omad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you

@omad omad merged commit 624f9ef into opendatacube:develop Nov 16, 2023
6 of 7 checks passed
@pjonsson pjonsson deleted the gdal-3.8.0-base branch November 17, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants