Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to jsonschema 4.18 #560

Merged
merged 7 commits into from
Dec 4, 2023
Merged

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Dec 2, 2023

This fixes #546.

This is on top of #548, #549, and #554. The re-enabled tests in this PR do not pass without #554.


📚 Documentation preview 📚: https://datacube-explorer--560.org.readthedocs.build/en/560/

Reformatting will give spurious differences
after running the update.sh script.
Make the update script fix the STAC version
instead of having a comment inside the test
file.
This effectively renames the directory
called master to 1.0.0.
I am not sure if it is the schema update, or some
external change, but these versions are what are
returned from these tests now.
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d7fa351) 85.88% compared to head (5232789) 86.31%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #560      +/-   ##
===========================================
+ Coverage    85.88%   86.31%   +0.43%     
===========================================
  Files           26       26              
  Lines         3457     3457              
===========================================
+ Hits          2969     2984      +15     
+ Misses         488      473      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omad omad merged commit 3483cf3 into opendatacube:develop Dec 4, 2023
7 checks passed
@pjonsson pjonsson deleted the jsonschema-418 branch December 4, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix JSON schema validation issues in tests
2 participants