Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework stac api extension logic #591

Merged
merged 21 commits into from
Jun 13, 2024
Merged

Rework stac api extension logic #591

merged 21 commits into from
Jun 13, 2024

Conversation

Ariana-B
Copy link
Contributor

@Ariana-B Ariana-B commented Apr 11, 2024

Add parameters to SummaryStore.search_items to enable factoring the filter and sortby extensions into the database query, thus moving the logic out of _handle_search_request and search_stac_items in _stac.py, where it was previously causing issues when results were paginated, as highlighted in #579.

Also took the opportunity to fix logic that was missing or out of line with the STAC API spec, such as reported in #536 and initially attempted in #570.

The STAC API extension specs are sometimes unclear or ambiguous around expected behaviour, so I have chosen to interpret them in the ways that seem the most reasonable and consistent. Most notably,

  • sortby will ignore any undefined properties,
  • both sortby and filter will recognise any potential variant of a property name (stac name (ex: created), eo3 name (ex: odc:processing_datetime), and metadata type search field name (ex: creation_time)) as syntactically valid for that property.

📚 Documentation preview 📚: https://datacube-explorer--591.org.readthedocs.build/en/591/

@Ariana-B Ariana-B requested review from jeremyh and omad April 12, 2024 04:39
Copy link
Member

@omad omad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks okay, lets just release it and try it...

@omad omad merged commit 5b93679 into develop Jun 13, 2024
9 checks passed
@omad omad deleted the rework_store_search branch June 13, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants