More explicit error for removed Query extension #615
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the STAC API
Query
extension was previously implemented, it suffered from the same flaws in logic as the other API extensions, which meant that while it would return correct results, they risked being oddly distributed when pagination was involved. Since it is recommended to implement theFilter
extension instead ofQuery
, and since correctly re-implementingQuery
was not trivial, it was dropped in favour ofFilter
.As mentioned in #611,
pystac_client
will warn users if they try to usequery
, but will still return results without issue. The api itself will similarly quietly ignorequery
if provided.To avoid any silent failure issues down the line, return a 400 error if the request includes a
query
argument.📚 Documentation preview 📚: https://datacube-explorer--615.org.readthedocs.build/en/615/