Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DROP: fix(manifests): missing namespace in CM stack-config #51

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

sutaakar
Copy link

Cherrypick of project-codeflare#521

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Apr 16, 2024

@sutaakar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 10ffcf2 link false /test security
ci/prow/e2e-odh-cfo 10ffcf2 link true /test e2e-odh-cfo

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@astefanutti
Copy link

/lgtm

@astefanutti
Copy link

/approve

Copy link

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sutaakar sutaakar merged commit 8fc43d6 into opendatahub-io:main Apr 16, 2024
5 of 8 checks passed
@sutaakar sutaakar deleted the namespace-fix branch April 16, 2024 11:59
@sutaakar sutaakar restored the namespace-fix branch April 16, 2024 11:59
@sutaakar sutaakar deleted the namespace-fix branch April 16, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants