Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.9-branch] RHOAIENG-10827: feat(nbcs): update ose-oauth-proxy image digest reference from 4.8 to the latest 4.14 version #388

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #386

/assign jiridanek

Copy link

openshift-ci bot commented Sep 19, 2024

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@shalberd
Copy link

Thanks for all the good work. Quick question: in ODH, operator v2.x versions and related deployments, are you already using kubeflow v1.9 branch or is this something coming up soon?

@jiridanek
Copy link
Member

Quick question: in ODH, operator v2.x versions and related deployments, are you already using kubeflow v1.9 branch or is this something coming up soon?

https://issues.redhat.com/browse/RHOAIENG-11649

Copy link

openshift-ci bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 99e70bf into opendatahub-io:v1.9-branch Sep 27, 2024
13 checks passed
harshad16 added a commit to harshad16/odh-kubeflow that referenced this pull request Oct 15, 2024
…oxy image digest reference from 4.8 to the latest 4.14 version (opendatahub-io#388)"

This reverts commit 99e70bf.
jiridanek added a commit to jiridanek/kubeflow that referenced this pull request Oct 16, 2024
…oxy image digest reference from 4.8 to the latest 4.14 version (opendatahub-io#388)"

We found at least one OCP cluster where this change causes restart of running notebooks when controller is updated from a previous version
to a version with this fix present. To be safe, we'll roll this back and try again. We'll investigate that cluster to understand what's happening.

This reverts commit 99e70bf.
openshift-merge-bot bot added a commit that referenced this pull request Oct 16, 2024
Revert "[v1.9-branch] RHOAIENG-10827: feat(nbcs): update ose-oauth-proxy image digest reference from 4.8 to the latest 4.14 version (#388)"
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/kubeflow that referenced this pull request Oct 16, 2024
…oxy image digest reference from 4.8 to the latest 4.14 version (opendatahub-io#388)"

We found at least one OCP cluster where this change causes restart of running notebooks when controller is updated from a previous version
to a version with this fix present. To be safe, we'll roll this back and try again. We'll investigate that cluster to understand what's happening.

This reverts commit 99e70bf.
jiridanek added a commit that referenced this pull request Nov 6, 2024
…oauth-proxy image digest reference from 4.8 to the latest 4.14 version (#388)""
openshift-merge-bot bot added a commit that referenced this pull request Nov 6, 2024
…h_proxy_update

RHOAIENG-14552: Reapply "RHOAIENG-10827: feat(nbcs): update ose-oauth-proxy image digest reference from 4.8 to the latest 4.14 version (#388)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants