-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-14687] Extend tests for certificate to assure that they are readable #435
[RHOAIENG-14687] Extend tests for certificate to assure that they are readable #435
Conversation
components/odh-notebook-controller/controllers/notebook_controller_test.go
Outdated
Show resolved
Hide resolved
ee9ed5c
to
9117408
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
was around while this was being made, so no complaints from me
The e2e tests are failing due to an infra issue and are irrelevant for changes in this PR anyway, so overriding: /override ci/prow/odh-notebook-controller-e2e |
@jstourac: Overrode contexts on behalf of jstourac: ci/prow/odh-notebook-controller-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm Also today the e2e is working! |
Thank you for the review, @atheo89
well, if you're judging only based on the result here - actually I overrode them as they are irrelevant for this change anyway 👼 |
Thank you all. I'm gonna merge this to move on. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstourac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ad75ae8
into
opendatahub-io:main
https://issues.redhat.com/browse/RHOAIENG-14687
Description
How Has This Been Tested?
In
components/odh-notebook-controller
runmake test
.Merge criteria: