Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-14687] Extend tests for certificate to assure that they are readable #435

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

jstourac
Copy link
Member

https://issues.redhat.com/browse/RHOAIENG-14687

Description

How Has This Been Tested?

In components/odh-notebook-controller run make test.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jstourac jstourac self-assigned this Oct 30, 2024
Copy link
Member

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

was around while this was being made, so no complaints from me

@jstourac
Copy link
Member Author

The e2e tests are failing due to an infra issue and are irrelevant for changes in this PR anyway, so overriding:

/override ci/prow/odh-notebook-controller-e2e

Copy link

openshift-ci bot commented Oct 30, 2024

@jstourac: Overrode contexts on behalf of jstourac: ci/prow/odh-notebook-controller-e2e

In response to this:

The e2e tests are failing due to an infra issue and are irrelevant for changes in this PR anyway, so overriding:

/override ci/prow/odh-notebook-controller-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@atheo89
Copy link
Member

atheo89 commented Oct 31, 2024

/lgtm

Also today the e2e is working!

@jstourac
Copy link
Member Author

Thank you for the review, @atheo89

Also today the e2e is working!

well, if you're judging only based on the result here - actually I overrode them as they are irrelevant for this change anyway 👼

@jstourac
Copy link
Member Author

Thank you all. I'm gonna merge this to move on.

/approve

Copy link

openshift-ci bot commented Oct 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ad75ae8 into opendatahub-io:main Oct 31, 2024
12 checks passed
@jstourac jstourac deleted the RHOAIENG-14687 branch October 31, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants