Merge pull request #600 from caponetto/RHOAIENG-8779

Add daily check for vulnerability issues using Trivy
opendatahub-io · Jul 2, 2024 · d7b7438 · d7b7438
2 parents 3f93529 + bc66678
commit d7b7438
Show file tree

Hide file tree

Showing 4 changed files with 101 additions and 3 deletions.
diff --git a/.github/workflows/build-notebooks-TEMPLATE.yaml b/.github/workflows/build-notebooks-TEMPLATE.yaml
@@ -43,6 +43,14 @@ jobs:
 
           df -h
 
+          sudo apt-get update
+          sudo apt-get remove -y '^dotnet-.*'
+          sudo apt-get remove -y '^llvm-.*'
+          sudo apt-get remove -y 'php.*'
+          sudo apt-get remove -y '^mongodb-.*'
+          sudo apt-get autoremove -y
+          sudo apt-get clean
+          sudo rm -rf /usr/local/.ghcup &
           sudo rm -rf /usr/local/lib/android &
           sudo rm -rf /usr/local/share/boost &
           sudo rm -rf /usr/local/lib/node_modules &
@@ -96,14 +104,40 @@ jobs:
           mkdir -p $HOME/.local/share/containers/storage/tmp
 
       # https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#push
-      - name: "push: make ${{ inputs.target }}"
+      - name: "push|schedule: make ${{ inputs.target }}"
         run: "make ${{ inputs.target }}"
-        if: "${{ fromJson(inputs.github).event_name == 'push' }}"
+        if: ${{ fromJson(inputs.github).event_name == 'push' || fromJson(inputs.github).event_name == 'schedule' }}
         env:
           IMAGE_TAG: "${{ github.ref_name }}_${{ github.sha }}"
           IMAGE_REGISTRY: "ghcr.io/${{ github.repository }}/workbench-images"
           CONTAINER_BUILD_CACHE_ARGS: "--cache-from ${{ env.CACHE }} --cache-to ${{ env.CACHE }}"
 
+      - name: "schedule: run Trivy vulnerability scanner"
+        if: "${{ fromJson(inputs.github).event_name == 'schedule' }}"
+        run: |
+          TRIVY_VERSION=0.52.2
+          REPORT_FOLDER=${{ github.workspace }}/report
+          REPORT_FILE=trivy-report.md
+          REPORT_TEMPLATE=trivy-markdown.tpl
+
+          mkdir -p $REPORT_FOLDER
+          cp ci/$REPORT_TEMPLATE $REPORT_FOLDER
+
+          IMAGE_NAME=ghcr.io/${{ github.repository }}/workbench-images:${{ inputs.target }}-${{ github.ref_name }}_${{ github.sha }}
+          echo "Scanning $IMAGE_NAME"
+
+          podman run --rm \
+              -v $REPORT_FOLDER:/report \
+              docker.io/aquasec/trivy:$TRIVY_VERSION \
+                image \
+                --scanners vuln,secret \
+                --exit-code 0 --timeout 30m \
+                --severity CRITICAL,HIGH \
+                --format template --template "@/report/$REPORT_TEMPLATE" -o /report/$REPORT_FILE \
+                $IMAGE_NAME
+
+          cat $REPORT_FOLDER/$REPORT_FILE >> $GITHUB_STEP_SUMMARY
+
       # https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request
       - name: "pull_request: make ${{ inputs.target }}"
         run: |

diff --git a/.github/workflows/build-notebooks.yaml b/.github/workflows/build-notebooks.yaml
@@ -7,7 +7,12 @@
     },
     "on": {
         "push": {},
-        "workflow_dispatch": {}
+        "workflow_dispatch": {},
+        "schedule": [
+            {
+                "cron": "0 2 * * *"
+            }
+        ]
     },
     "jobs": {
         "base-ubi8-python-3_8": {

diff --git a/ci/cached-builds/gen_gha_matrix_jobs.py b/ci/cached-builds/gen_gha_matrix_jobs.py
@@ -106,6 +106,7 @@ def write_github_workflow_file(tree: dict[str, list[str]], path: pathlib.Path) -
         "on": {
             "push": {},
             "workflow_dispatch": {},
+            "schedule": [{ "cron": "0 2 * * *"}], # 2am UTC everyday
         },
         "jobs": jobs,
     }

diff --git a/ci/trivy-markdown.tpl b/ci/trivy-markdown.tpl
@@ -0,0 +1,58 @@
+## Vulnerability Report by [Trivy](https://trivy.dev)
+
+<details>
+  {{- if . }}
+    {{- range . }}
+      {{- if or (gt (len .Vulnerabilities) 0) (gt (len .Misconfigurations) 0) }}
+        <h3>Target: <code>{{- if and (eq .Class "os-pkgs") .Type }}{{ .Type | toString | escapeXML }} ({{ .Class | toString | escapeXML }}){{- else }}{{ .Target | toString | escapeXML }}{{ if .Type }} ({{ .Type | toString | escapeXML }}){{ end }}{{- end }}</code></h3>
+        {{- if (gt (len .Vulnerabilities) 0) }}
+          <h4>Vulnerabilities ({{ len .Vulnerabilities }})</h4>
+          <table>
+              <tr>
+                  <th>Package</th>
+                  <th>ID</th>
+                  <th>Severity</th>
+                  <th>Installed Version</th>
+                  <th>Fixed Version</th>
+              </tr>
+              {{- range .Vulnerabilities }}
+                <tr>
+                    <td><code>{{ escapeXML .PkgName }}</code></td>
+                    <td>{{ escapeXML .VulnerabilityID }}</td>
+                    <td>{{ escapeXML .Severity }}</td>
+                    <td>{{ escapeXML .InstalledVersion }}</td>
+                    <td>{{ escapeXML .FixedVersion }}</td>
+                </tr>
+              {{- end }}
+          </table>
+        {{- end }}
+        {{- if (gt (len .Misconfigurations ) 0) }}
+          <h4>Misconfigurations</h4>
+          <table>
+              <tr>
+                  <th>Type</th>
+                  <th>ID</th>
+                  <th>Check</th>
+                  <th>Severity</th>
+                  <th>Message</th>
+              </tr>
+              {{- range .Misconfigurations }}
+                <tr>
+                    <td>{{ escapeXML .Type }}</td>
+                    <td>{{ escapeXML .ID }}</td>
+                    <td>{{ escapeXML .Title }}</td>
+                    <td>{{ escapeXML .Severity }}</td>
+                    <td>
+                      {{ escapeXML .Message }}
+                      <br><a href={{ escapeXML .PrimaryURL | printf "%q" }}>{{ escapeXML .PrimaryURL }}</a></br>
+                    </td>
+                </tr>
+              {{- end }}
+          </table>
+        {{- end }}
+      {{- end }}
+    {{- end }}
+  {{- else }}
+    <h3>Empty report</h3>
+  {{- end }}
+</details>