Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the pytorch image reference in main to commit e868e30 #250

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

harshad16
Copy link
Member

Fix the pytorch image reference in main to commit e868e30

Description

The digest for the pytorch image on the main, is referencing the base c9s image not the pytorch
this fixes the issue.
Related-to: #246

How Has This Been Tested?

Execute the following

podman run -p 8888:8888 quay.io/opendatahub/workbench-images@sha256:fc11d04f90817c15969203bced343f65ba7e3b10cb16861706e788da368f61f0

or

make deploy9-jupyter-pytorch-ubi9-python-3.9 -e IMAGE_REGISTRY="quay.io/opendatahub/workbench-images" -e NOTEBOOK_TAG=jupyter-pytorch-ubi9-python-3.9-2023a-20230929-e868e30
make test-jupyter-pytorch-ubi9-python-3.9
make undeploy9-jupyter-pytorch-ubi9-python-3.9

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@atheo89
Copy link
Member

atheo89 commented Oct 10, 2023

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16
Copy link
Member Author

/override ci/prow/notebooks-e2e-tests
/override ci/prow/images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

@harshad16: Overrode contexts on behalf of harshad16: ci/prow/images, ci/prow/notebooks-e2e-tests

In response to this:

/override ci/prow/notebooks-e2e-tests
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 451c9c9 into opendatahub-io:main Oct 10, 2023
3 checks passed
@atheo89 atheo89 mentioned this pull request Oct 20, 2023
@harshad16 harshad16 deleted the fix-pytorch-image-main branch October 20, 2023 18:25
@harshad16 harshad16 mentioned this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants