Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-8255: Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm download location #553

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Jun 6, 2024

Jira: https://issues.redhat.com/browse/RHOAIENG-8255

Description

Previously used location is now unavailable and returns 404 error.

This new location comes from https://koji.fedoraproject.org/koji/buildinfo?buildID=2028619

How Has This Been Tested?

Docker build succeeded

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Previously used location is now unavailable and returns 404 error.

This new location comes from https://koji.fedoraproject.org/koji/buildinfo?buildID=2028619
@adelton
Copy link

adelton commented Jun 7, 2024

Technically that package exists there in koji ... but it is not signed there and koji is not really meant to be used by external production deployments. Per https://dl.fedoraproject.org/pub/fedora/linux/releases/37/README, https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/37/Everything/x86_64/os/Packages/s/spawn-fcgi-1.6.3-23.fc37.x86_64.rpm is likely the location to used.

But it is still a one-off build of the software which no longer receives security updates in Fedora (otherwise we would just used a fc40 build). Isn't this a chance to fix the issue properly, either finding different approach that spawn-fcgi, or assuming maintainership of it in EPEL, build it properly there, and use those builds?

@jiridanek
Copy link
Member Author

jiridanek commented Jun 7, 2024

https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/37/Everything/x86_64/os/Packages/s/spawn-fcgi-1.6.3-23.fc37.x86_64.rpm

Thanks for that, I was looking for it in "fedora archives" and I did not ctrl+f it under Packages/s/ myself. Not sure what I did wrong. Will use your link for sure!

Copy link
Member

@atheo89 atheo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix. It looks like we are good for now! I have opened a ticket to track its deprecation and plan a move to another solution in the future:
https://issues.redhat.com/browse/RHOAIENG-8298

Please remember to apply this fix to the downstream RHEL flavor as well: 🙂
https://github.com/red-hat-data-services/notebooks/blob/main/rstudio/rhel9-python-3.9/Dockerfile#L94

/lgtm
/approve

@atheo89
Copy link
Member

atheo89 commented Jun 7, 2024

/override ci/prow/images
/override ci/prow/notebooks-e2e-tests

Copy link
Contributor

openshift-ci bot commented Jun 7, 2024

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/images, ci/prow/notebooks-e2e-tests

In response to this:

/override ci/prow/images
/override ci/prow/notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2d8899f into opendatahub-io:main Jun 7, 2024
7 checks passed
@jiridanek jiridanek deleted the jd_fsomething_cgi_workaround branch June 7, 2024 14:04
@jiridanek
Copy link
Member Author

/cherrypick 2023b

@openshift-cherrypick-robot

@jiridanek: new pull request created: #569

In response to this:

/cherrypick 2023b

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

/cherrypick 2023a

@openshift-cherrypick-robot

@jiridanek: new pull request created: #617

In response to this:

/cherrypick 2023a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants