-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-8255: Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm download location #553
RHOAIENG-8255: Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm download location #553
Conversation
Previously used location is now unavailable and returns 404 error. This new location comes from https://koji.fedoraproject.org/koji/buildinfo?buildID=2028619
Technically that package exists there in koji ... but it is not signed there and koji is not really meant to be used by external production deployments. Per https://dl.fedoraproject.org/pub/fedora/linux/releases/37/README, https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/37/Everything/x86_64/os/Packages/s/spawn-fcgi-1.6.3-23.fc37.x86_64.rpm is likely the location to used. But it is still a one-off build of the software which no longer receives security updates in Fedora (otherwise we would just used a fc40 build). Isn't this a chance to fix the issue properly, either finding different approach that spawn-fcgi, or assuming maintainership of it in EPEL, build it properly there, and use those builds? |
Thanks for that, I was looking for it in "fedora archives" and I did not ctrl+f it under Packages/s/ myself. Not sure what I did wrong. Will use your link for sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix. It looks like we are good for now! I have opened a ticket to track its deprecation and plan a move to another solution in the future:
https://issues.redhat.com/browse/RHOAIENG-8298
Please remember to apply this fix to the downstream RHEL flavor as well: 🙂
https://github.com/red-hat-data-services/notebooks/blob/main/rstudio/rhel9-python-3.9/Dockerfile#L94
/lgtm
/approve
/override ci/prow/images |
@atheo89: Overrode contexts on behalf of atheo89: ci/prow/images, ci/prow/notebooks-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: jstourac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick 2023b |
@jiridanek: new pull request created: #569 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherrypick 2023a |
@jiridanek: new pull request created: #617 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Jira: https://issues.redhat.com/browse/RHOAIENG-8255
Description
Previously used location is now unavailable and returns 404 error.
This new location comes from https://koji.fedoraproject.org/koji/buildinfo?buildID=2028619
How Has This Been Tested?
Docker build succeeded
Merge criteria: