-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: implement ghcr.io expiration for images and cache layers #601
ci: implement ghcr.io expiration for images and cache layers #601
Conversation
aedd3be
to
8870662
Compare
Co-authored-by: Guilherme Caponetto <[email protected]>
Are we sure that sufficient time has been allocated to inspect the Trivy report before this workflow proceed to prune the images? |
I don't see it as an issue since the workflow prunes images that are 3 weeks old. We can always resort to the latest report/image if necessary. |
we could push |
Ahhh ok i got it!
That's fine Jiri! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atheo89, caponetto, jstourac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
…ahub-io#601) * ci: implement ghcr.io expiration for images and cache layers * fixups from rewiew, reference action by hash not tag Co-authored-by: Guilherme Caponetto <[email protected]> --------- Co-authored-by: Guilherme Caponetto <[email protected]>
Description
Fixes #568
How Has This Been Tested?
See the action in action at https://github.com/jiridanek/notebooks/actions/runs/9717613825/job/26823642202#step:3:18
The repos this is cleaning are https://github.com/jiridanek/notebooks/pkgs/container/notebooks%2Fworkbench-images and https://github.com/jiridanek/notebooks/pkgs/container/notebooks%2Fworkbench-images%2Fbuild-cache
Merge criteria: