Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of the TrustyAI version in the Jupyter TrustyAI notebook #615

Merged

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented Jul 11, 2024

The version of the TrustyAI package in the N-1 (2023b) image is actually 0.6.0 for some time already, see [1].

[1] https://issues.redhat.com/browse/RHOAIENG-4027


  • Does this need any backports into the other upstream branches?
  • This needs to be aligned also in downstream in following branches: main, rhoai-2.12, rhoai-2.10 (technically also rhoai-2.11, but we don't care probably anymore).

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

The version of the TrustyAI package in the N-1 (2023b) image is actually
0.6.0 for some time already, see [1].

[1] https://issues.redhat.com/browse/RHOAIENG-4027
Copy link
Member

@atheo89 atheo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jul 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstourac
Copy link
Member Author

/override ci/prow/images

I don't believe we need these for such change, though, I expect that bot will tell me I don't have rights to do the above action.

Copy link
Contributor

openshift-ci bot commented Jul 12, 2024

@jstourac: jstourac unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

In response to this:

/override ci/prow/images

I don't believe we need these for such change, though, I expect that bot will tell me I don't have rights to do the above action.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@atheo89
Copy link
Member

atheo89 commented Jul 12, 2024

prow/images build in every PR if we are in hurry we can override them in this one

@openshift-merge-bot openshift-merge-bot bot merged commit e506603 into opendatahub-io:main Jul 12, 2024
6 checks passed
@jstourac jstourac deleted the updateTrustyManifest branch July 15, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants