-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinned down jupyter-server-proxy for cve fixes #630
Pinned down jupyter-server-proxy for cve fixes #630
Conversation
Skipping CI for Draft Pull Request. |
@jstourac guess we should try this image out on a gaudi-enabled machine as part of 2.8 release testing, or possibly now (tomorrow), using a PR build, wdyt? /lgtm |
The CVE seems to have disappeared: https://quay.io/repository/opendatahub/workbench-images/manifest/sha256:d6c44c0bc78a4fd4fd272f1edfa44924d73ffd971ce17ed884700dcef762808c?tab=vulnerabilities /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atheo89 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
||
# Parent image requirements to maintain cohesion | ||
jupyterlab = "~=3.5.3" | ||
jupyter-server = "~=2.1.0" | ||
jupyter-server-proxy = "~=3.2.2" | ||
jupyter-server-proxy = "~=3.2.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fully fixed release is 3.2.4, but since the ~=
is used, it is installed anyway, see https://quay.io/repository/opendatahub/workbench-images/manifest/sha256:d6c44c0bc78a4fd4fd272f1edfa44924d73ffd971ce17ed884700dcef762808c?tab=packages
yeah, we should check the image still work with habana hw and that e.g. a pipeline can be executed properly at least |
/hold |
- Pinned kfp-tekton due the requirements changing pyyaml. - Pinned rest of the packages for dependency resolutions. Signed-off-by: Harshad Reddy Nalla <[email protected]>
d4fcb18
to
061c6fb
Compare
/test images |
/test notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror |
I've tried https://docs.habana.ai/en/v1.10.0/TensorFlow/Migration_Guide/Porting_Simple_TensorFlow_Model_to_Gaudi.html#creating-a-tensorflow-example with http://quay.io/opendatahub/workbench-images:habana-jupyter-1.10.0-ubi8-python-3.8-pr-630, runs fine, and in pip list i see
so /lgtm |
/lgtm |
/unhold |
@harshad16: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/override ci/prow/habana-notebooks-e2e-tests |
@harshad16: Overrode contexts on behalf of harshad16: ci/prow/habana-notebooks-e2e-tests, ci/prow/images, ci/prow/notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror, ci/prow/rocm-notebooks-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/hold |
/test notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror |
959183c
into
opendatahub-io:main
/cherrypick 2023b |
@jiridanek: new pull request created: #677 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Related-to: https://issues.redhat.com/browse/RHOAIENG-6456
These changes upgrade the
jupyter-server-proxy
to fix the CVE.Next steps:
How Has This Been Tested?
Build image via Makefile
Merge criteria: