Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned down jupyter-server-proxy for cve fixes #630

Conversation

harshad16
Copy link
Member

  • Pinned kfp-tekton due the requirements changing pyyaml.
  • Pinned rest of the packages for dependency resolutions.

Description

Related-to: https://issues.redhat.com/browse/RHOAIENG-6456
These changes upgrade the jupyter-server-proxy to fix the CVE.

Next steps:

  • Built as part of 2023b, lets backport this in that version.

How Has This Been Tested?

Build image via Makefile

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Jul 22, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@harshad16 harshad16 marked this pull request as ready for review July 22, 2024 15:15
@jiridanek
Copy link
Member

jiridanek commented Jul 22, 2024

@jstourac guess we should try this image out on a gaudi-enabled machine as part of 2.8 release testing, or possibly now (tomorrow), using a PR build, wdyt?

/lgtm

@atheo89
Copy link
Member

atheo89 commented Jul 23, 2024

Copy link
Contributor

openshift-ci bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


# Parent image requirements to maintain cohesion
jupyterlab = "~=3.5.3"
jupyter-server = "~=2.1.0"
jupyter-server-proxy = "~=3.2.2"
jupyter-server-proxy = "~=3.2.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jstourac
Copy link
Member

@jstourac guess we should try this image out on a gaudi-enabled machine as part of 2.8 release testing, or possibly now (tomorrow), using a PR build, wdyt?

yeah, we should check the image still work with habana hw and that e.g. a pipeline can be executed properly at least

@harshad16
Copy link
Member Author

/hold

- Pinned kfp-tekton due the requirements changing pyyaml.
- Pinned rest of the packages for dependency resolutions.

Signed-off-by: Harshad Reddy Nalla <[email protected]>
@harshad16 harshad16 force-pushed the fix-cve-jupyter-server-proxy branch from d4fcb18 to 061c6fb Compare July 24, 2024 21:20
@openshift-ci openshift-ci bot removed the lgtm label Jul 24, 2024
@jiridanek
Copy link
Member

/test images


@jiridanek
Copy link
Member

/test notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror

@jiridanek
Copy link
Member

I've tried https://docs.habana.ai/en/v1.10.0/TensorFlow/Migration_Guide/Porting_Simple_TensorFlow_Model_to_Gaudi.html#creating-a-tensorflow-example with http://quay.io/opendatahub/workbench-images:habana-jupyter-1.10.0-ubi8-python-3.8-pr-630, runs fine, and in pip list i see

(app-root) (app-root) pip list | grep jupyter
jupyter-bokeh                   3.0.7
jupyter_client                  7.4.9
jupyter_core                    5.7.2
jupyter-events                  0.10.0
jupyter-lsp                     2.2.5
jupyter_packaging               0.12.3
jupyter-resource-usage          0.7.2
jupyter_server                  2.1.0
jupyter_server_fileid           0.9.2
jupyter-server-mathjax          0.2.6
jupyter-server-proxy            3.2.4
jupyter_server_terminals        0.4.4
jupyter_server_ydoc             0.8.0
jupyter-ydoc                    0.2.5
jupyterlab                      3.5.3
jupyterlab-git                  0.41.0
jupyterlab-lsp                  3.10.2
jupyterlab_pygments             0.3.0
jupyterlab_server               2.27.3
jupyterlab_widgets              3.0.11

so /lgtm

@jstourac
Copy link
Member

/lgtm

@harshad16
Copy link
Member Author

/unhold

Copy link
Contributor

openshift-ci bot commented Jul 30, 2024

@harshad16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror d4fcb18 link true /test runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror
ci/prow/runtime-rocm-tensorflow-ubi9-python-3-9-pr-image-mirror d4fcb18 link true /test runtime-rocm-tensorflow-ubi9-python-3-9-pr-image-mirror
ci/prow/runtimes-ubi9-e2e-tests d4fcb18 link true /test runtimes-ubi9-e2e-tests
ci/prow/rocm-runtimes-ubi9-e2e-tests d4fcb18 link true /test rocm-runtimes-ubi9-e2e-tests
ci/prow/runtimes-ubi8-e2e-tests d4fcb18 link true /test runtimes-ubi8-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@harshad16
Copy link
Member Author

/override ci/prow/habana-notebooks-e2e-tests
/override ci/prow/images
/override ci/prow/notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror
/override ci/prow/rocm-notebooks-e2e-tests

Copy link
Contributor

openshift-ci bot commented Jul 30, 2024

@harshad16: Overrode contexts on behalf of harshad16: ci/prow/habana-notebooks-e2e-tests, ci/prow/images, ci/prow/notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror, ci/prow/rocm-notebooks-e2e-tests

In response to this:

/override ci/prow/habana-notebooks-e2e-tests
/override ci/prow/images
/override ci/prow/notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror
/override ci/prow/rocm-notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@harshad16
Copy link
Member Author

/hold

@harshad16
Copy link
Member Author

/test notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror

@openshift-merge-bot openshift-merge-bot bot merged commit 959183c into opendatahub-io:main Jul 30, 2024
10 checks passed
@jiridanek
Copy link
Member

/cherrypick 2023b

@openshift-cherrypick-robot

@jiridanek: new pull request created: #677

In response to this:

/cherrypick 2023b

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants