RHOAIENG-10783: fix(Dockerfiles): combine fix-permissions RUN with the preceding RUN when possible
#635
Conversation
jiridanek
added
trivy-scan
jiridanek
changed the title
fix-permissions RUN with the preceding RUN when possible
I linked the Fixes #539, isn't it sufficient? I'll copy the desc from there to here then.
Not sure which is better. The previous RUN commands change (#634) was not tracked under anything. This makes the image for trivy scan smaller, so it should be fine to track under trivy, i think. |
jiridanek
changed the title
fix-permissions RUN with the preceding RUN when possiblefix-permissions RUN with the preceding RUN when possible
|
/lgtm Thank you 🎸 |
|
@jiridanek could you please rebase this PR to pick up #652? |
jiridanek
force-pushed
the
jd_nocachedir
branch
from
ea7dec8
to
024098e
Compare
|
/lgtm |
|
/override ci/prow/images |
|
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/habana-notebooks-e2e-tests, ci/prow/images, ci/prow/notebooks-ubi8-e2e-tests, ci/prow/notebooks-ubi9-e2e-tests, ci/prow/rocm-notebooks-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
these are the first four newly built images after the changes |
looking at latest main, pytorch, where the savings are the most significant, shrank by ~5GB by doing this! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/notebooks-ubi8-e2e-tests failed due to failed image builds, known issue already present on main |
|
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/notebooks-ubi8-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override nosuchjob |
|
@jiridanek: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/habana-notebooks-e2e-tests |
|
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/habana-notebooks-e2e-tests, ci/prow/images, ci/prow/notebook-cuda-jupyter-ds-ubi8-python-3-8-pr-image-mirror, ci/prow/notebook-cuda-jupyter-ds-ubi9-python-3-9-pr-image-mirror, ci/prow/notebook-cuda-jupyter-minimal-ubi8-python-3-8-pr-image-mirror, ci/prow/notebook-cuda-jupyter-minimal-ubi9-python-3-9-pr-image-mirror, ci/prow/notebook-cuda-jupyter-tf-ubi9-python-3-9-pr-image-mirror, ci/prow/notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror, ci/prow/notebook-habana-1-13-0-ubi8-python-3-8-pr-image-mirror, ci/prow/notebook-jupyter-datascience-ubi8-python-3-8-pr-image-mirror, ci/prow/notebook-jupyter-datascience-ubi9-python-3-9-pr-image-mirror, ci/prow/notebook-jupyter-minimal-ubi8-python-3-8-pr-image-mirror, ci/prow/notebook-jupyter-minimal-ubi9-python-3-9-pr-image-mirror, ci/prow/notebook-jupyter-pytorch-ubi9-python-3-9-pr-image-mirror, ci/prow/notebook-jupyter-trustyai-ubi9-python-3-9-pr-image-mirror, ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-9-pr-image-mirror, ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-9-pr-image-mirror, ci/prow/notebooks-ubi8-e2e-tests, ci/prow/notebooks-ubi9-e2e-tests, ci/prow/rocm-notebooks-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jiridanek: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/override ci/prow/notebook-cuda-jupyter-ds-ubi9-python-3-9-pr-image-mirror |
|
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/notebook-cuda-jupyter-ds-ubi9-python-3-9-pr-image-mirror, ci/prow/notebook-cuda-jupyter-minimal-ubi9-python-3-9-pr-image-mirror, ci/prow/notebook-jupyter-pytorch-ubi9-python-3-9-pr-image-mirror In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* Add images based on python 3.11 * Apply #656 to Python 3.11 images * Fix expected TF vesion on the test file * Fix labels for Python 3.11 * Apply #652 to Python 3.11 images * Update lock to fix debugpy package version * Apply #635 to Python 3.11 images * Replace 3-9 -> 3-11 leftovers * Fix runtime rocm image name according to openshift/release * Apply #667 to Python 3.11 images * Adapt test code for Python 3.11 images
Fixes #539
Makes changes to more images than
RUNcommands to reduce rocm image size #634Description
The below step in jupyter-pytorch-ubi9-python-3_9 and probably other images creates a large layer. Fix the permissions in the previous step already.
from https://docs.docker.com/storage/storagedriver/
How Has This Been Tested?
Build images in CI, check sizes.
After:
Before:
The pytorch images show the largest size difference, for the other images the impact is very small.
Merge criteria: