Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-9822: chore(Makefile): allow not pushing built images in Makefile and allow skipping building dependent images #657

Merged

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Aug 1, 2024

https://issues.redhat.com/browse/RHOAIENG-9822

Description

Follow-up to

How Has This Been Tested?

the failure in ^^^ is infra instability

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
…efile and allow skipping building dependent images

Co-authored-by: Guilherme Caponetto <[email protected]>
@caponetto
Copy link
Contributor

/lgtm

@jstourac
Copy link
Member

jstourac commented Aug 7, 2024

/lgtm

Thanks, this is nice! 🌟

@jiridanek
Copy link
Member Author

/override ci/prow/images
/override ci/prow/rocm-notebooks-e2e-tests

/approve

Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images, ci/prow/rocm-notebooks-e2e-tests

In response to this:

/override ci/prow/images
/override ci/prow/rocm-notebooks-e2e-tests

/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ed363c7 into opendatahub-io:main Aug 7, 2024
8 checks passed
@jiridanek jiridanek deleted the jd_conditional_makefile branch August 9, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants