Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runtime updater workflow to search for the new ROCm runtimes #683

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Aug 21, 2024

Related to: https://issues.redhat.com/browse/RHOAIENG-6445

Description

This PR updates the runtime updater workflow to search for the new ROCm runtimes.

How Has This Been Tested?

Here it is a local repo that simulates the behaviour of the workflow link

Test digest updater evluation: #684

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jiridanek
Copy link
Member

/lgtm
i don't understand it enough, but from the linked gha run it looks like it works

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Great work 👍

Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstourac
Copy link
Member

/override ci/prow/rocm-notebooks-e2e-tests

Copy link
Contributor

openshift-ci bot commented Aug 22, 2024

@jstourac: Overrode contexts on behalf of jstourac: ci/prow/rocm-notebooks-e2e-tests

In response to this:

/override ci/prow/rocm-notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit ed61c20 into opendatahub-io:main Aug 22, 2024
8 checks passed
@atheo89 atheo89 deleted the RHOAIENG-6445 branch October 23, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants