Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the kfp package version in image manifest to match the reality #688

Merged

Conversation

jstourac
Copy link
Member

Since the Kfp has been updated to 2.8 version recently, we should update also the relevant image manifests to match this situation.

This is to narrow the situation described in https://issues.redhat.com/browse/RHOAIENG-9643 - Kfp 2.8 is part of the images in RHOAI 2.12 already.

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Since the Kfp has been updated to 2.8 version recently, we should update
also the relevant image manifests to match this situation.
@jstourac jstourac self-assigned this Aug 28, 2024
@jstourac
Copy link
Member Author

/override ci/prow/rocm-notebooks-e2e-tests
/override ci/prow/images

These changes have no effect on the images builds, it's just a metadata change.
Also, I have raised this openshift/release#56074 to fix the condition when the rocm e2e tests are being triggered.

Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images, ci/prow/rocm-notebooks-e2e-tests

In response to this:

/override ci/prow/rocm-notebooks-e2e-tests
/override ci/prow/images

These changes have no effect on the images builds, it's just a metadata change.
Also, I have raised this openshift/release#56074 to fix the condition when the rocm e2e tests are being triggered.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member

/lgtm

Copy link
Member

@atheo89 atheo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89
Copy link
Member

atheo89 commented Aug 29, 2024

/override ci/prow/rocm-notebooks-e2e-tests

Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/rocm-notebooks-e2e-tests

In response to this:

/override ci/prow/rocm-notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 46fa998 into opendatahub-io:main Aug 29, 2024
8 checks passed
@jstourac jstourac deleted the kfpVersionManifest branch August 29, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants