Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-12195: Update TrustyAI dependencies #697

Merged

Conversation

ruivieira
Copy link
Member

  • See RHOAIENG-12195
  • Update TrustyAI to 0.6.1 (adds support for TMaRCo local models, see RHOAIENG-12554)
  • Add PyTorch, transformers, datasets and accelerate as TrustyAI notebook image dependencies

Description

In order to add support for disconnected use and for local models in TrustyAI's TMaRCo/Detoxification, this PR changes the following:

  • Update TrustyAI version to 0.6.1
  • Add the PyTorch, transformers, datasets and accelerate dependencies. These were previously optional.

How Has This Been Tested?

Updated example on using local models with TMaRCo to be added with trustyai-explainability/trustyai-explainability-python-examples#43

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

- Update TrustyAI to 0.6.1 (adds support for TMaRCo local models)
- Add PyTorch, transformers, datasets and accelerate as TrustyAI notebook image dependencies
[dev-packages]

[packages]
# PyTorch packages
torch = {version = "~=2.2.1", index = "pytorch"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we should check how much the new images are bigger and whether we're okay with that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jstourac According to a cursory look this increase the image size (on the registry) from ~1GiB to ~5Gib.

@ruivieira ruivieira marked this pull request as ready for review September 12, 2024 11:23
…tyai

# Conflicts:
#	jupyter/trustyai/ubi9-python-3.11/Pipfile
#	jupyter/trustyai/ubi9-python-3.11/Pipfile.lock
Copy link
Member

@atheo89 atheo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ruivieira for your PR, it /lgtm 🙂
I was able to spin up the notebook via podman run -it -p 8888:8888 quay.io/opendatahub/workbench-images:jupyter-trustyai-ubi9-python-3.11-pr-697 without any complains. TBH I didn't test it along with detoxification module.

Copy link
Contributor

openshift-ci bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89
Copy link
Member

atheo89 commented Sep 18, 2024

/override ci/prow/images
/override ci/prow/notebooks-ubi9-e2e-tests

Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/images, ci/prow/notebooks-ubi9-e2e-tests

In response to this:

/override ci/prow/images
/override ci/prow/notebooks-ubi9-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@atheo89
Copy link
Member

atheo89 commented Sep 18, 2024

/override ci/prow/images
/override ci/prow/notebooks-ubi9-e2e-tests

Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/images, ci/prow/notebooks-ubi9-e2e-tests

In response to this:

/override ci/prow/images
/override ci/prow/notebooks-ubi9-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit d4183a4 into opendatahub-io:main Sep 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants