-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-12195: Update TrustyAI dependencies #697
RHOAIENG-12195: Update TrustyAI dependencies #697
Conversation
- Update TrustyAI to 0.6.1 (adds support for TMaRCo local models) - Add PyTorch, transformers, datasets and accelerate as TrustyAI notebook image dependencies
[dev-packages] | ||
|
||
[packages] | ||
# PyTorch packages | ||
torch = {version = "~=2.2.1", index = "pytorch"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: we should check how much the new images are bigger and whether we're okay with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jstourac According to a cursory look this increase the image size (on the registry) from ~1GiB to ~5Gib.
…tyai # Conflicts: # jupyter/trustyai/ubi9-python-3.11/Pipfile # jupyter/trustyai/ubi9-python-3.11/Pipfile.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ruivieira for your PR, it /lgtm 🙂
I was able to spin up the notebook via podman run -it -p 8888:8888 quay.io/opendatahub/workbench-images:jupyter-trustyai-ubi9-python-3.11-pr-697
without any complains. TBH I didn't test it along with detoxification module.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atheo89 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/images |
@atheo89: Overrode contexts on behalf of atheo89: ci/prow/images, ci/prow/notebooks-ubi9-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/images |
@atheo89: Overrode contexts on behalf of atheo89: ci/prow/images, ci/prow/notebooks-ubi9-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
d4183a4
into
opendatahub-io:main
Description
In order to add support for disconnected use and for local models in TrustyAI's TMaRCo/Detoxification, this PR changes the following:
How Has This Been Tested?
Updated example on using local models with TMaRCo to be added with trustyai-explainability/trustyai-explainability-python-examples#43
Merge criteria: