Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated odh-elyra from 4.0.0.dev1 to 4.0.0rc0 #715

Merged

Conversation

paulovmr
Copy link
Contributor

Description

Updated odh-elyra from 4.0.0.dev1 to 4.0.0rc0.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jstourac
Copy link
Member

/lgtm

@paulovmr
Copy link
Contributor Author

/retest

1 similar comment
@paulovmr
Copy link
Contributor Author

/retest

@harshad16
Copy link
Member

Note for the record:

The ENV vars for elyra disconnected are removed as, they have be directly included in upstream for maximizing the effort, with this change, even if users brings their own runtime image without basing from our runtime images, they would be able to execute them.
The bootstrapper.py file wouldn't be only looked up in local file system, will also be checked if not present to fallback on the upstream based file URL.
opendatahub-io/elyra#44

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 1, 2024
@harshad16
Copy link
Member

/override ci/prow/images
/override ci/prow/notebooks-ubi9-e2e-tests
/override ci/prow/rocm-notebooks-e2e-tests

Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

@harshad16: Overrode contexts on behalf of harshad16: ci/prow/images, ci/prow/notebooks-ubi9-e2e-tests, ci/prow/rocm-notebooks-e2e-tests

In response to this:

/override ci/prow/images
/override ci/prow/notebooks-ubi9-e2e-tests
/override ci/prow/rocm-notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit eb433fc into opendatahub-io:main Oct 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants