Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upversion OAuth Proxy to 4.14 #3216

Merged

Conversation

andrewballantyne
Copy link
Member

@andrewballantyne andrewballantyne commented Sep 18, 2024

https://issues.redhat.com/browse/RHOAIENG-10450

Description

Upversioning the version of OAuth Proxy based on architectural guidance.

How Has This Been Tested?

Will host it on a non-FIPS cluster to test stability. Will test also that nothing development wise breaks.

Seeing if I can get a FIPS enabled cluster before merging.

Spinning down the Operator & Applying the OAuth Container image sha value

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@andrewballantyne
Copy link
Member Author

/hold

Waiting on image to test.

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.47%. Comparing base (b5351a7) to head (6d95c02).
Report is 15 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3216      +/-   ##
==========================================
+ Coverage   85.39%   85.47%   +0.08%     
==========================================
  Files        1277     1279       +2     
  Lines       28082    28161      +79     
  Branches     7487     7525      +38     
==========================================
+ Hits        23980    24070      +90     
+ Misses       4102     4091      -11     

see 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5351a7...6d95c02. Read the comment docs.

@andrewballantyne
Copy link
Member Author

/unhold

Solution works.

Before:
Screenshot 2024-09-18 at 12 11 49 PM
Screenshot 2024-09-18 at 12 11 56 PM

After:
image
image

@openshift-ci openshift-ci bot removed the do-not-merge/hold This PR is hold for some reason label Sep 18, 2024
@christianvogt
Copy link
Contributor

Tested the oauth proxy image on my ROSA cluster and was successful in logging in/out.

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 089ff71 into opendatahub-io:main Sep 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants