-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upversion OAuth Proxy to 4.14 #3216
Upversion OAuth Proxy to 4.14 #3216
Conversation
/hold Waiting on image to test. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3216 +/- ##
==========================================
+ Coverage 85.39% 85.47% +0.08%
==========================================
Files 1277 1279 +2
Lines 28082 28161 +79
Branches 7487 7525 +38
==========================================
+ Hits 23980 24070 +90
+ Misses 4102 4091 -11 see 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Tested the oauth proxy image on my ROSA cluster and was successful in logging in/out. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-10450
Description
Upversioning the version of OAuth Proxy based on architectural guidance.
How Has This Been Tested?
Will host it on a non-FIPS cluster to test stability. Will test also that nothing development wise breaks.
Seeing if I can get a FIPS enabled cluster before merging.
Spinning down the Operator & Applying the OAuth Container image sha value
Test Impact
N/A
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main