Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soucis de validation de badge des datasets #1564

Closed
maudetes opened this issue Nov 7, 2024 · 0 comments · Fixed by opendatateam/udata#3191 · May be fixed by opendatateam/udata#3189
Closed

Soucis de validation de badge des datasets #1564

maudetes opened this issue Nov 7, 2024 · 0 comments · Fixed by opendatateam/udata#3191 · May be fixed by opendatateam/udata#3189
Labels
💙 Back Les tickets de back Bug Indique qu’il s’agit d’un problème

Comments

@maudetes
Copy link
Contributor

maudetes commented Nov 7, 2024 •
edited
Loading

Erreur sentry

Les JDDs "de référence" ont comme badge "spd", ex https://www.data.gouv.fr/api/1/datasets/base-sirene-des-entreprises-et-de-leurs-etablissements-siren-siret/.
Cependant, le badge spd est défini côté udata-front et est inconnu côté udata.

Le refacto du système de badge a probablement cassé cette mécanique d'ajouts de badges dans les plugins.

Cela fait maintenant échouer la validation et donc toute modification de ces JDDs.

Il faut donc permettre l'extension des badges dans udata-front, ou les rajouter directement dans udata.
@maudetes maudetes converted this from a draft issue Nov 7, 2024
@maudetes maudetes added Bug Indique qu’il s’agit d’un problème 💙 Back Les tickets de back labels Nov 7, 2024
@maudetes maudetes mentioned this issue Nov 8, 2024
Open
@maudetes maudetes moved this from 📝 Todo to 🛠 Doing in 🚀 Produit data.gouv.fr Nov 8, 2024
@magopian magopian mentioned this issue Nov 12, 2024
Merged
magopian added a commit to opendatateam/udata that referenced this issue Nov 14, 2024
@magopian @maudetes
Allow override of badges (#3191)
2825e9b 
Follows up on #3189, fixes
[#1564](datagouv/data.gouv.fr#1564)

---------

Co-authored-by: maudetes <[email protected]>
@github-project-automation github-project-automation bot moved this from 🛠 Doing to ✅ Done in 🚀 Produit data.gouv.fr Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💙 Back Les tickets de back Bug Indique qu’il s’agit d’un problème
Projects
🚀 Produit data.gouv.fr
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow override of badges opendatateam/udata
Allow override of dataset badges maudetes/udata
1 participant
@maudetes