Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow override of badges #3191

Merged
merged 7 commits into from
Nov 14, 2024
Merged

Allow override of badges #3191

merged 7 commits into from
Nov 14, 2024

Conversation

magopian
Copy link
Contributor

Follows up on #3189, fixes #1564

maudetes
maudetes approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think we're good 👏

Don't forget the changelog ;)

udata/core/badges/tests/test_model.py Outdated Show resolved Hide resolved
@magopian magopian merged commit 2825e9b into master Nov 14, 2024
1 check passed
@maudetes maudetes deleted the allow-override-of-badges branch November 14, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolinocroustibat bolinocroustibat Awaiting requested review from bolinocroustibat

@ThibaudDauce ThibaudDauce Awaiting requested review from ThibaudDauce

@nicolaskempf57 nicolaskempf57 Awaiting requested review from nicolaskempf57

@maudetes maudetes Awaiting requested review from maudetes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Soucis de validation de badge des datasets
2 participants
@magopian @maudetes