Added resource.preview_url and display it (fix #1564) #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abulte
approved these changes
Apr 12, 2018
There was a problem hiding this comment.
Comments here, I made them in the wrong place somehow :-/ https://github.com/noirbizarre/udata/commit/564ba681414ce227a3189d2b18e48992ee826a9d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial data preview support through the
resource.preview_url.The behavior is configurable with the
PREVIEW_MODEparameter:'iframe'(default): displays the preview into a modal iframe'page': displays the preview into a blank new pageNone: previewing is disabledResource card with preview button
iframemode