Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No lowercasing of branch to fix pipeline matching #714

Merged
merged 4 commits into from
Jul 21, 2023
Merged

No lowercasing of branch to fix pipeline matching #714

merged 4 commits into from
Jul 21, 2023

Conversation

henrjk
Copy link
Member

@henrjk henrjk commented Jul 12, 2023 •
edited
Loading

Fixes #713

Tasks:

  • [NA] Updated design documents in docs/design directory or not applicable
  • [NA] Updated user-facing documentation in docs directory or not applicable
  • [NA] Ran tests (e.g. make test) or not applicable
  • Updated changelog or not applicable

@henrjk henrjk marked this pull request as ready for review July 17, 2023 13:52
@michaelsauter
Copy link
Member

LGTM. I would add a note to the changelog as this is a user-facing change. It fixes bug #713.

@henrjk
Copy link
Member Author

henrjk commented Jul 20, 2023

LGTM. I would add a note to the changelog as this is a user-facing change. It fixes bug #713.

Makes sense will do that soon.

@henrjk henrjk changed the title no lowercasing of branch to fix pipeline matching No lowercasing of branch to fix pipeline matching Jul 20, 2023
michaelsauter
michaelsauter requested changes Jul 20, 2023
View reviewed changes
CHANGELOG.md Outdated
@@ -20,6 +20,8 @@ listed in the changelog.

- Gradle build dir is now configurable ([#703](https://github.com/opendevstack/ods-pipeline/pull/703))

- ods.yaml branch trigger patterns must be lowercase ([#713](https://github.com/opendevstack/ods-pipeline/issues/713))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an outdated changelog. If you rebase on master you'll see that there is a 0.13.2 release and the line you added should actually go above that, into the "Unreleased" section. I would suggest under "Fixed" - or "Changed"?

@henrjk henrjk force-pushed the fix/branch-pattern-case-match branch from eb17845 to 5c23cb9 Compare July 20, 2023 16:21
@michaelsauter
Copy link
Member

Hmm, the Go task tests fail in the sonar step. Do you have an idea if / how that could be related?

@michaelsauter
Copy link
Member

Actually, https://github.com/opendevstack/ods-pipeline/actions/runs/5584494350 failed as well, also in regards to SQ, but for different tasks. Maybe there is a general issue I need to look into.

@henrjk
Copy link
Member Author

henrjk commented Jul 21, 2023

Actually, https://github.com/opendevstack/ods-pipeline/actions/runs/5584494350 failed as well, also in regards to SQ, but for different tasks. Maybe there is a general issue I need to look into.

:-) I was starting to look at it. But haven't found an issue. There should be no impact on the go tasks though in this PR I'd say.

@michaelsauter michaelsauter merged commit 6e17f53 into master Jul 21, 2023
14 of 15 checks passed
@michaelsauter michaelsauter deleted the fix/branch-pattern-case-match branch July 21, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsauter michaelsauter michaelsauter requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ods.yaml branch trigger patterns must be lowercase
2 participants
@henrjk @michaelsauter